This repository was archived by the owner on May 20, 2023. It is now read-only.
Components update #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ___Breaking Change:___ Remove `NoopStream` in favor of `Stream.empty()` as provided by the SDK. * Material Select: * Unified template files (deleted material_select_dropdown_item.html). * Add support for `Selectable` `SelectionOptions`. * Create a `ControlValueAccessor`. * Add backspace and delete keys to `KeyboardHandlerMixin`. * Add `selectedValue` getter to `RadioGroupSingleSelectionModel`. * Add null check to `ObservableComposite`'s `register` method. * Add `totalEntitiesCountChange` getter to table selection models. * Add `isStandardMouseEvent` utility to test for clicks without modifier keys. * Migrate use of LazyEventController to StreamController. * Strong mode fixes.
|
Build broken by the dartium 50 roll but a fix is already in that should make it green. dart-lang/sdk@fbbb974 |
|
If this build is green I will update the commit message with the current notes from the changelog when I squash and merge. |
kevmoo
approved these changes
May 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoopStreamin favor ofStream.empty()asprovided by the SDK.
SelectableSelectionOptions.ControlValueAccessor.KeyboardHandlerMixin.selectedValuegetter toRadioGroupSingleSelectionModel.ObservableComposite'sregistermethod.totalEntitiesCountChangegetter to table selection models.isStandardMouseEventutility to test for clicks without modifier keys.