feat: add shutdown methods stop scan stop advertise and status #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 1, 2023 13:54
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
They are called in native shutdown Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
berendsliedrecht
previously requested changes
Jun 1, 2023
android/src/main/java/com/reactnativebledidcomm/central/CentralManager.kt
Show resolved
Hide resolved
android/src/main/java/com/reactnativebledidcomm/BleDidcommModule.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/reactnativebledidcomm/peripheral/PeripheralManager.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
Nice. thanks for the quick feedback! Much appreciated. |
added 5 commits
June 2, 2023 16:21
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
TimoGlastra
approved these changes
Jun 5, 2023
android/src/main/java/com/reactnativebledidcomm/BleDidcommModule.kt
Outdated
Show resolved
Hide resolved
added 4 commits
June 5, 2023 19:28
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
janrtvld
reviewed
Jun 7, 2023
Signed-off-by: Moriarty <[email protected]>
morrieinmaas
dismissed
berendsliedrecht’s stale review
on holiday and timo approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.