fix: added empty object to shutdown method #50
Conversation
Signed-off-by: Jan <[email protected]>
Signed-off-by: Jan <[email protected]>
berendsliedrecht
left a comment
berendsliedrecht
left a comment
There was a problem hiding this comment.
Has this been tested with:
- Create connection
- Send message (arrives)
- Disconnect
- Send message (error)
for both sides?
| for (device in connectedDevices) { | ||
| this.gattServer.cancelConnection(device) | ||
| } | ||
| this.gattServer.close() |
There was a problem hiding this comment.
Shouldn't we close the gattServer when we stop advertising?
There was a problem hiding this comment.
I've moved the close to the stopAdvertising function.
|
|
||
| @ReactMethod | ||
| fun shutdownCentral( | ||
| @Suppress("UNUSED_PARAMETER") options: ReadableMap, |
There was a problem hiding this comment.
Central needs no changes?
There was a problem hiding this comment.
Do you mean the same changes as in the peripheralManager? The central shutdown works fine without those changes.
There was a problem hiding this comment.
Not the same changes per se. As long as it is tested with the flow I mentioned above it is fine.
Signed-off-by: Jan <[email protected]>
|
Why do we need the empty object? |
I am not sure on the internals, tried finding information about it before, but a function without any params needs an empty object to work. It might be fixable by tweaking the Objective-C interface, but this seems to be a fine solution to me. |
|
Can we add a comment? I would remove this I it wouldn't have a comment 😉 |
Signed-off-by: Jan <[email protected]>
3 participants
No description provided.