Range verification and vulnerability scan improvements#84
Merged
anirbanbasu merged 8 commits intoJan 15, 2026
Conversation
…specifications of invalid values. feat: Removed UVICORN_LIMIT_MAX_REQUESTS in the view of allowing the server to run forever on hosted environments such as FastMCP cloud.
dosubot
Bot
added
the
size:L
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances configuration validation and removes a server limit to support continuous operation on hosted environments. It adds Range validators to prevent invalid environment variable values, removes the UVICORN_LIMIT_MAX_REQUESTS setting to allow indefinite server runtime, and documents security considerations from vulnerability scans.
Changes:
- Added Range validation to 11 environment variables (timeouts, cache sizes, rate limits, and request sizes)
- Removed UVICORN_LIMIT_MAX_REQUESTS configuration and its references throughout the codebase
- Updated documentation with acceptable value ranges and security considerations from Airtable vulnerability scan
- Updated dependencies: cyclopts (4.4.5→4.4.6), prometheus-client (0.24.0→0.24.1), ty (0.0.11→0.0.12)
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Dependency updates for cyclopts, prometheus-client, ty, and version bump to 0.4.4 |
| src/frankfurtermcp/init.py | Added Range validators to environment variables and commented out UVICORN_LIMIT_MAX_REQUESTS |
| src/frankfurtermcp/server.py | Removed UVICORN_LIMIT_MAX_REQUESTS from logging and uvicorn.run() call |
| src/frankfurtermcp/middleware.py | Added clarifying comment about max_body_size behavior when set to 0 or less |
| README.md | Updated documentation with acceptable ranges, security considerations section, and commented out UVICORN_LIMIT_MAX_REQUESTS |
| .env.template | Commented out UVICORN_LIMIT_MAX_REQUESTS variable |
| pyproject.toml | Version bump from 0.4.3 to 0.4.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ault value and valid range.
anirbanbasu
deleted the
83-improve-vulnerability-rating-further-and-fix-rate-limiter-configuration
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83