Skip to content

fix(lsp): ignore stderr on LSP server spawn to prevent unbounded memory growth #16241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dimaosipa wants to merge 8 commits into from
+45 −3
Closed

fix(lsp): ignore stderr on LSP server spawn to prevent unbounded memory growth #16241

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fd0a4b1
fix: ignore stderr on LSP server spawn to prevent unbounded memory gr…
dimaosipa Mar 5, 2026
5f5dea9
Merge branch 'dev' into fix/lsp-stderr-memory-leak
dimaosipa Mar 8, 2026
fcdcab2
Merge branch 'dev' into fix/lsp-stderr-memory-leak
dimaosipa Mar 8, 2026
442a3b5
Merge branch 'dev' into fix/lsp-stderr-memory-leak
dimaosipa Mar 11, 2026
9741b33
Merge branch 'dev' into fix/lsp-stderr-memory-leak
dimaosipa Mar 12, 2026
6670d5c
Merge branch 'dev' into fix/lsp-stderr-memory-leak
dimaosipa Mar 16, 2026
87ebef7
Merge branch 'dev' into fix/lsp-stderr-memory-leak
dimaosipa Mar 24, 2026
6b1300b
Merge branch 'dev' into fix/lsp-stderr-memory-leak
dimaosipa Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/opencode/src/lsp/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ export namespace LSP {
...process.env,
...item.env,
},
stdio: ["pipe", "pipe", "ignore"],
}),
initialization: item.initialization,
}
Expand Down
47 changes: 44 additions & 3 deletions packages/opencode/src/lsp/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { spawn, type ChildProcessWithoutNullStreams } from "child_process"
import { spawn, type ChildProcess } from "child_process"
import path from "path"
import os from "os"
import { Global } from "../global"
Expand All @@ -22,7 +22,7 @@ export namespace LSPServer {
.catch(() => false)

export interface Handle {
process: ChildProcessWithoutNullStreams
process: ChildProcess
initialization?: Record<string, any>
}

Expand Down Expand Up @@ -83,6 +83,7 @@ export namespace LSPServer {
return {
process: spawn(deno, ["lsp"], {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand All @@ -105,6 +106,7 @@ export namespace LSPServer {
...process.env,
BUN_BE_BUN: "1",
},
stdio: ["pipe", "pipe", "ignore"],
})
return {
process: proc,
Expand Down Expand Up @@ -156,6 +158,7 @@ export namespace LSPServer {
...process.env,
BUN_BE_BUN: "1",
},
stdio: ["pipe", "pipe", "ignore"],
})
return {
process: proc,
Expand Down Expand Up @@ -216,6 +219,7 @@ export namespace LSPServer {
...process.env,
BUN_BE_BUN: "1",
},
stdio: ["pipe", "pipe", "ignore"],
})

return {
Expand Down Expand Up @@ -273,6 +277,7 @@ export namespace LSPServer {
return {
process: spawn(lintBin, ["--lsp"], {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
}
Expand All @@ -288,6 +293,7 @@ export namespace LSPServer {
return {
process: spawn(serverBin, [], {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
}
Expand Down Expand Up @@ -351,6 +357,7 @@ export namespace LSPServer {
...process.env,
BUN_BE_BUN: "1",
},
stdio: ["pipe", "pipe", "ignore"],
})

return {
Expand Down Expand Up @@ -395,6 +402,7 @@ export namespace LSPServer {
return {
process: spawn(bin!, {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand Down Expand Up @@ -435,6 +443,7 @@ export namespace LSPServer {
return {
process: spawn(bin!, ["--lsp"], {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand Down Expand Up @@ -495,6 +504,7 @@ export namespace LSPServer {

const proc = spawn(binary, ["server"], {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
})

return {
Expand Down Expand Up @@ -550,6 +560,7 @@ export namespace LSPServer {
...process.env,
BUN_BE_BUN: "1",
},
stdio: ["pipe", "pipe", "ignore"],
})
return {
process: proc,
Expand Down Expand Up @@ -615,6 +626,7 @@ export namespace LSPServer {
return {
process: spawn(binary, {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand Down Expand Up @@ -727,6 +739,7 @@ export namespace LSPServer {
return {
process: spawn(bin, {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand Down Expand Up @@ -766,6 +779,7 @@ export namespace LSPServer {
return {
process: spawn(bin, {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand Down Expand Up @@ -805,6 +819,7 @@ export namespace LSPServer {
return {
process: spawn(bin, {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand All @@ -822,6 +837,7 @@ export namespace LSPServer {
return {
process: spawn(sourcekit, {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
}
Expand All @@ -839,6 +855,7 @@ export namespace LSPServer {
return {
process: spawn(bin, {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand Down Expand Up @@ -885,6 +902,7 @@ export namespace LSPServer {
return {
process: spawn(bin, {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand All @@ -901,6 +919,7 @@ export namespace LSPServer {
return {
process: spawn(fromPath, args, {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
}
Expand All @@ -911,6 +930,7 @@ export namespace LSPServer {
return {
process: spawn(direct, args, {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
}
Expand All @@ -924,6 +944,7 @@ export namespace LSPServer {
return {
process: spawn(candidate, args, {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
}
Expand Down Expand Up @@ -1031,6 +1052,7 @@ export namespace LSPServer {
return {
process: spawn(bin, args, {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand Down Expand Up @@ -1068,6 +1090,7 @@ export namespace LSPServer {
...process.env,
BUN_BE_BUN: "1",
},
stdio: ["pipe", "pipe", "ignore"],
})
return {
process: proc,
Expand Down Expand Up @@ -1115,6 +1138,7 @@ export namespace LSPServer {
...process.env,
BUN_BE_BUN: "1",
},
stdio: ["pipe", "pipe", "ignore"],
})
return {
process: proc,
Expand Down Expand Up @@ -1222,6 +1246,7 @@ export namespace LSPServer {
],
{
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
},
),
}
Expand Down Expand Up @@ -1314,6 +1339,7 @@ export namespace LSPServer {
return {
process: spawn(launcherScript, ["--stdio"], {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand Down Expand Up @@ -1360,6 +1386,7 @@ export namespace LSPServer {
...process.env,
BUN_BE_BUN: "1",
},
stdio: ["pipe", "pipe", "ignore"],
})
return {
process: proc,
Expand Down Expand Up @@ -1502,6 +1529,7 @@ export namespace LSPServer {
return {
process: spawn(bin, {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand Down Expand Up @@ -1539,6 +1567,7 @@ export namespace LSPServer {
...process.env,
BUN_BE_BUN: "1",
},
stdio: ["pipe", "pipe", "ignore"],
})
return {
process: proc,
Expand All @@ -1564,6 +1593,7 @@ export namespace LSPServer {
return {
process: spawn(prisma, ["language-server"], {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand All @@ -1582,6 +1612,7 @@ export namespace LSPServer {
return {
process: spawn(dart, ["language-server", "--lsp"], {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand All @@ -1600,6 +1631,7 @@ export namespace LSPServer {
return {
process: spawn(bin, {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand Down Expand Up @@ -1636,6 +1668,7 @@ export namespace LSPServer {
...process.env,
BUN_BE_BUN: "1",
},
stdio: ["pipe", "pipe", "ignore"],
})
return {
process: proc,
Expand Down Expand Up @@ -1715,6 +1748,7 @@ export namespace LSPServer {
return {
process: spawn(bin, ["serve"], {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
initialization: {
experimentalFeatures: {
Expand Down Expand Up @@ -1811,6 +1845,7 @@ export namespace LSPServer {
return {
process: spawn(bin, {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand Down Expand Up @@ -1848,6 +1883,7 @@ export namespace LSPServer {
...process.env,
BUN_BE_BUN: "1",
},
stdio: ["pipe", "pipe", "ignore"],
})
return {
process: proc,
Expand All @@ -1868,6 +1904,7 @@ export namespace LSPServer {
return {
process: spawn(gleam, ["lsp"], {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand All @@ -1889,6 +1926,7 @@ export namespace LSPServer {
return {
process: spawn(bin, ["listen"], {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand Down Expand Up @@ -1920,6 +1958,7 @@ export namespace LSPServer {
env: {
...process.env,
},
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand Down Expand Up @@ -2014,7 +2053,7 @@ export namespace LSPServer {
}

return {
process: spawn(bin, { cwd: root }),
process: spawn(bin, { cwd: root, stdio: ["pipe", "pipe", "ignore"] }),
}
},
}
Expand All @@ -2032,6 +2071,7 @@ export namespace LSPServer {
return {
process: spawn(bin, ["--lsp"], {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand All @@ -2050,6 +2090,7 @@ export namespace LSPServer {
return {
process: spawn(julia, ["--startup-file=no", "--history-file=no", "-e", "using LanguageServer; runserver()"], {
cwd: root,
stdio: ["pipe", "pipe", "ignore"],
}),
}
},
Expand Down
Loading