Skip to content

Fix selection expansion by retaining focused input selections during global key events #20205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hona merged 4 commits into from
Apr 1, 2026
Merged

Fix selection expansion by retaining focused input selections during global key events #20205

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
526ec0f
fix(tui): preserve focused text selection on Windows
Hona Mar 31, 2026
a9be1b1
fix(tui): clear stale prompt selections on Windows
Hona Mar 31, 2026
58b6bae
Merge remote-tracking branch 'upstream/dev' into fix/windows-prompt-t…
Hona Apr 1, 2026
3803ab4
fix(tui): simplify prompt text selection clear check
Hona Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/opencode/src/cli/cmd/tui/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,8 @@ function App(props: { onSnapshot?: () => Promise<string[]> }) {

useKeyboard((evt) => {
if (!Flag.OPENCODE_EXPERIMENTAL_DISABLE_COPY_ON_SELECT) return
if (!renderer.getSelection()) return
const sel = renderer.getSelection()
if (!sel) return

// Windows Terminal-like behavior:
// - Ctrl+C copies and dismisses selection
Expand All @@ -323,6 +324,9 @@ function App(props: { onSnapshot?: () => Promise<string[]> }) {
return
}

const focus = renderer.currentFocusedRenderable
if (focus?.hasSelection() && sel.selectedRenderables.includes(focus)) return
Comment thread
Hona marked this conversation as resolved.
Outdated

renderer.clearSelection()
})

Expand Down
Loading