refactor(database): unify PostgreSQL/SQLite schemas via dialect shim#32255
Closed
jadsongmatos wants to merge 16 commits into
Closed
refactor(database): unify PostgreSQL/SQLite schemas via dialect shim#32255jadsongmatos wants to merge 16 commits into
jadsongmatos wants to merge 16 commits into
Conversation
Updated the explore agent's role and operational guidelines for file searching.
Add dual SQLite/PostgreSQL database backend. When OPENCODE_DATABASE_URL is set to a postgres:// or postgresql:// URL, opencode uses PostgreSQL instead of SQLite. No consumer code changes required. - Add DatabaseDialect module to detect backend from env var - Add effect-drizzle-pg package for Drizzle PG integration - Add .pg.ts schema files for all tables with bigint timestamps - Add conditional exports in sql.ts files (dialect-aware at runtime) - Add pg-bootstrap.ts for fresh PG database initialization - Add applyPg() migration path with bootstrap + incremental pgUp - Add pg.layer.ts and #pg conditional import in package.json - Add docker-compose.yml for local PG development - Add project_directory and new permission tables to PG bootstrap - Update database.ts to route based on dialect detection
Add @effect/sql-pg, pg, @libsql/client, and new @opencode-ai/effect-drizzle-pg package for PostgreSQL support. This enables using PostgreSQL as a database backend alongside existing SQLite.
…(wgzesg/feat/configurable-database-backend)
- Add dialect shim (dialect.ts, dialect.sqlite.ts, dialect.pg.ts) with type mappings:
text({mode:'json'})→jsonb(), integer()→bigint({mode:'number'}), integer({mode:'boolean'})→boolean(), real()→doublePrecision()
- Migrate 9 sql.ts files to import from shim, removing isPostgres() dispatch and .pg.ts duplicates:
credential, account, permission, event, share, project, data-migration, control-plane/workspace, session
- Remove 10 .pg.ts files + schema.sql.ts, schema.pg.ts, path.pg.ts, pg-bootstrap.ts
- Simplify tables.ts (no dispatch), migration.ts (no pg-bootstrap), path.ts (customType from shim), schema.ts (re-export Timestamps)
- Fix project.test.ts: imports, fs.promises.realpath, ProjectV2.Directories test data, withRepo remote
- database.ts retains DatabaseDialect.isPostgres() for runtime driver selection (correct)
Implements dialect shim pattern from wgzesg/opencode#feat/configurable-database-backend
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
github-actions
Bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential duplicate found:
This PR has the exact same title as the current PR #32255. They are likely addressing the same refactoring work with the dialect shim pattern. You should verify whether one is a duplicate or supersedes the other. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements dialect shim pattern (from wgzesg/feat/configurable-database-backend) to unify PostgreSQL and SQLite schemas without duplicate .pg.ts files.
Changes
Add dialect shim (dialect.ts, dialect.sqlite.ts, dialect.pg.ts) with type mappings:
Migrate 9 sql.ts files to import from shim, removing isPostgres() dispatch and .pg.ts duplicates:
Remove 10 .pg.ts files + schema.sql.ts, schema.pg.ts, path.pg.ts, pg-bootstrap.ts
Simplify tables.ts (no dispatch), migration.ts (no pg-bootstrap), path.ts (customType from shim), schema.ts (re-export Timestamps)
Fix project.test.ts: imports, fs.promises.realpath, ProjectV2.Directories test data, withRepo remote
Testing
Closes #14212