fix(app): show agent picker by default in new layout#32277
fix(app): show agent picker by default in new layout#32277devinoldenburg wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
needs:compliance
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Enables the “custom agents” feature by default in app settings, changing the initial UX for users who don’t already have an explicit preference stored.
Changes:
- Flip
showCustomAgentsdefault fromfalsetotrue.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:
|
Enabling "New Layout and Designs" hid the composer's agent picker and disabled the agent-cycle shortcut, so Plan/Build could no longer be switched (issue anomalyco#31972). In the new layout, `visibility.customAgents()` collapses to the `showCustomAgents` preference, which defaulted to `false`. That gated both `showAgentControl` (the composer picker) and the `agent.cycle` commands (mod+.), unlike the old layout which always showed the picker. Default `showCustomAgents` to `true` so the agent picker and agent cycling work out of the box, restoring parity with the old layout. The setting remains toggleable and explicit user overrides are respected.
devinoldenburg
force-pushed
the
show-agent-picker
branch
from
ec8a4ed to
46042e7
Compare
github-actions
Bot
removed
the
needs:compliance
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
actually, I checked and did not find those. |
Issue for this PR
Closes #31972
Type of change
What does this PR do?
With "New Layout and Designs" on you can't switch between Plan and Build anymore: the agent picker is gone from the composer and
mod+.does nothing.Both are gated by
settings.visibility.customAgents(), which in the new layout reduces to theshowCustomAgentspreference (!newLayoutDesigns() || showCustomAgents()). It defaults tofalse, soshowAgentControlinprompt-input.tsxis false (picker hidden) and theagent.cyclecommands inuse-session-commands.tsxaredisabled(shortcut dead). The old layout always renders the picker, so this only regresses under the new layout.The picker lists
local.agent.list()— primary agents (mode !== "subagent"), i.e. the Build/Plan switcher. That's a core control, so it shouldn't be hidden by default.The fix flips the
showCustomAgentsdefault totrue. Picker andmod+.work again, the setting is still toggleable, and anyone who explicitly turned it off keeps that choice (withFallbackonly uses the default when the key is absent).#30352 fixes the picker at the component level but leaves the keyboard shortcut broken; this restores both.
How did you verify your code works?
bun typecheckpasses forpackages/appand the full workspace (the pre-push hook runsturbo typecheckacross all 23 packages). I ran the app locally with the new layout enabled to check the composer (screenshot below). Reasoning: with the new defaultvisibility.customAgents()istrue, soshowAgentControlrenders the picker and theagent.cyclecommands are no longerdisabled.Screenshots / recordings
Build/Plan picker restored in the composer (new layout):
Checklist