Rewrite of cloud.py with a new licence#488
Conversation
|
@jillr could you please have a look and see if there are missing features? |
ansibullbot
added
community_review
feature
|
check ondemand |
9ba549e to
3ea795d
Compare
|
@goneri I believe you also have familiarity with this and have examined the original cloud.py, could you please add a review? |
|
recheck |
4 similar comments
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
abikouo
changed the title
36e8ea3 to
c734345
Compare
tremble
left a comment
tremble
left a comment
There was a problem hiding this comment.
Looks good, thanks for the changes. I'd still like to see a test that retries is properly respected, but otherwise LGTM.
|
recheck |
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
|
recheck |
|
Before gating we need to move this back from |
|
recheck |
2808477 to
1401ce1
Compare
…of class.base_class
1401ce1 to
3cc92b4
Compare
|
recheck |
|
The sanity failures will need to be fixed (metaclass and future import). The ec2_eni failure is a waiter timeout thhat rechecks should help with and the ec2_metadata_facts timeout should be addressed by #498 when it merges (oh Amazon, you and your latency and eventual consistency :)). |
bb2450d to
4bf4347
Compare
|
recheck |
3 similar comments
|
recheck |
|
recheck |
|
recheck |
|
Every CI failure since the sanity fix has been a timeout (either zuul or aws). We're running the collection's full set of integration tests which is always (in the current config) at risk of hitting zuul's 1 hour time out. We've also been seeing substantial AWS latency the last couple says (ie; 15 minutes to boot instances in us-east-1). The effort needed to get a 2 test runs (check + gate) to pass exceeds the value of continuing to recheck. We have confidence that we've seen enough test successes over the course of our retries that all tests are actually green (if ansible-test-cloud-integration-aws-py36_2 fails on a timeout one time, and ansible-test-cloud-integration-aws-py36_4 is the thing that fails the next time, technically we've seen green results from both sets of tests). I've temporarily disabled branch protection and am bypassing zuul to merge this PR. |
…lections#488) Support new enableExecuteCommand options for ECS service SUMMARY Support new ecs exec feature for ECS service ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION Create ECS service with enable_execute_command option, - name: create exec service ecs_service: state: present ... enable_execute_command: true and we can exec ECS task $ aws ecs execute-command --cluster xxxxx --task arn:aws:ecs:us-east-1:*****:task/webapp/***** --container xxxxx --interactive --command /bin/bash The Session Manager plugin was installed successfully. Use the AWS CLI to start a session. Starting session with SessionId: ecs-execute-command-0c17f94b36227381f root@ip-10-0-66-68:/# Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis
…lections#488) Support new enableExecuteCommand options for ECS service SUMMARY Support new ecs exec feature for ECS service ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION Create ECS service with enable_execute_command option, - name: create exec service ecs_service: state: present ... enable_execute_command: true and we can exec ECS task $ aws ecs execute-command --cluster xxxxx --task arn:aws:ecs:us-east-1:*****:task/webapp/***** --container xxxxx --interactive --command /bin/bash The Session Manager plugin was installed successfully. Use the AWS CLI to start a session. Starting session with SessionId: ecs-execute-command-0c17f94b36227381f root@ip-10-0-66-68:/# Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis
…lections#488) Support new enableExecuteCommand options for ECS service SUMMARY Support new ecs exec feature for ECS service ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION Create ECS service with enable_execute_command option, - name: create exec service ecs_service: state: present ... enable_execute_command: true and we can exec ECS task $ aws ecs execute-command --cluster xxxxx --task arn:aws:ecs:us-east-1:*****:task/webapp/***** --container xxxxx --interactive --command /bin/bash The Session Manager plugin was installed successfully. Use the AWS CLI to start a session. Starting session with SessionId: ecs-execute-command-0c17f94b36227381f root@ip-10-0-66-68:/# Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis
6 participants
SUMMARY
Implement the specified functionality without referencing the plugins/module_utils/cloud.py file or tests, under BSD license.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Depends-On: #503