updates post vmware_rest release 4.0.0#89
Open
mikemorency wants to merge 7 commits intoansible-community:mainfrom
Open
updates post vmware_rest release 4.0.0#89mikemorency wants to merge 7 commits intoansible-community:mainfrom
mikemorency wants to merge 7 commits intoansible-community:mainfrom
Conversation
8a01a23 to
e7781c0
Compare
mariolenz
reviewed
Jan 13, 2025
Contributor
mariolenz
left a comment
There was a problem hiding this comment.
ATM I don't feel able to approve this because I'm not 100% sure that I understand the changes.
But maybe @anna-savina, @mikemorency, @prabinovRedhat or @shellymiron have something to say about this. They've contributed to vmware.vmware_rest recently and, at the end of the day, the idea is to generate this collection and not do manual changes. So maybe they have some useful insights or comments on this.
Contributor
Author
|
its been awhile, but heres the reason for different changes:
|
Contributor
|
Is this still up to date and needed? If yes, we might also change supports_check_mode to false while we're at it (see here) and start to nag people about merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
These are changes I had to make to succesfully generate content in vmware.vmware_rest release 4.0.0. It included a new openapi spec, which introduced some new data types (corresponding to existing or new modules).
Additionally, i had to update the asyncio initialization for python 3.12. The previous was of getting a loop has been deprecated. The method included in this PR passed python 3.8 + sanity checks
ISSUE TYPE
COMPONENT NAME
generate_cloud_modules
vmware_rest
ADDITIONAL INFORMATION
Related: ansible-collections/vmware.vmware_rest#511