Skip to content

Update pattern schema URL to point pattern-service repo #4673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Update pattern schema URL to point pattern-service repo #4673

wants to merge 3 commits into from
+43 −38

Conversation

shatakshiiii
Copy link
Contributor

@shatakshiiii shatakshiiii commented Jul 2, 2025 •
edited by ssbarnea
Loading

@shatakshiiii shatakshiiii force-pushed the pattern_schema_update branch from 9f59f34 to e7a3a91 Compare July 2, 2025 10:01
@shatakshiiii
Copy link
Contributor Author

shatakshiiii commented Jul 9, 2025 •
edited
Loading

Hi @ssbarnea @cidrblock, I need your inputs on this comment ansible/pattern-service#17 (comment).

ansible-lint's schemas are using the "examples" field for file glob patterns instead of actual JSON examples. And according to the JSON Schema specification the examples field should contain actual JSON data examples not file path patterns.

The ideal approach here would be to modify ansible-lint to use a different field name for file glob patterns and keep the "examples" field for actual JSON examples as per the JSON Schema specification. But this will require significant code changes in lint schema validation. WDYT, how should we proceed on this ?

ssbarnea
ssbarnea requested changes Jul 10, 2025
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect, $id must be a link to a jSON file and not github webpage. Correct url is the one with raw: https://raw.githubusercontent.com/ansible/pattern-service/refs/heads/main/specifications/pattern_specification.json

@ssbarnea
Copy link
Member

Put this on hold till we have patterns team publish their schema. We are blocked by them.

@shatakshiiii shatakshiiii changed the title Update pattern schema from URL pointing to pattern-service repo Update pattern schema URL to point to pattern-service repo Jul 11, 2025
@shatakshiiii shatakshiiii changed the title Update pattern schema URL to point to pattern-service repo Update pattern schema URL to point pattern-service repo Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement
Projects
🧰 devtools project board
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shatakshiiii @ssbarnea