-
Notifications
You must be signed in to change notification settings - Fork 8
Fix broken https link and wrap at 80 columns #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
|
||
Logging in PyAnsys Libraries | ||
============================ | ||
|
||
The logging capabilities in PyAnsys libraries should be built upon the | ||
`standard logging <https://docs.python.org/3/library/logging.html/>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for fixing something and reformatting at the same time. This is the broken link, I've fixed it below (removed the unecessary / char at the end).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dnwillia-ansys for fixing it.
Co-authored-by: Maxime Rey <[email protected]>
Agree with formatting changes. Thanks all. |
@akaszynski Regarding the two spaces thing not sure if I did that but I think this is very common practice when learning to type on a standard typewriter. It's engrained into you as part of the instruction, so I doubt I'd ever be able to stop myself from doing it, kind of automatic at this point. The important thing is that the documentation is consistent. One or two spaces is fine. |
@dnwillia-ansys It was already there. I fully agree with you, consistency is the more important. Thanks again for improving the documentation. |
There was a broken link in the section referring users to the Python
logging
documentation at:https://docs.python.org/3/library/logging.html
I also reformatted the paragraphs so you can see it within 80 columns in a text editor.