Skip to content

Fix broken https link and wrap at 80 columns #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Conversation

dnwillia-work
Copy link
Contributor

There was a broken link in the section referring users to the Python logging documentation at:

https://docs.python.org/3/library/logging.html

I also reformatted the paragraphs so you can see it within 80 columns in a text editor.



Logging in PyAnsys Libraries
============================

The logging capabilities in PyAnsys libraries should be built upon the
`standard logging <https://docs.python.org/3/library/logging.html/>`__
Copy link
Contributor Author

@dnwillia-work dnwillia-work Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for fixing something and reformatting at the same time. This is the broken link, I've fixed it below (removed the unecessary / char at the end).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dnwillia-ansys for fixing it.

@akaszynski
Copy link
Contributor

Agree with formatting changes. Thanks all.

@akaszynski akaszynski merged commit 51306b5 into main Jan 12, 2022
@akaszynski akaszynski deleted the dnwillia/fixlink branch January 12, 2022 20:05
@dnwillia-work
Copy link
Contributor Author

dnwillia-work commented Jan 12, 2022

@akaszynski Regarding the two spaces thing not sure if I did that but I think this is very common practice when learning to type on a standard typewriter. It's engrained into you as part of the instruction, so I doubt I'd ever be able to stop myself from doing it, kind of automatic at this point.

The important thing is that the documentation is consistent. One or two spaces is fine.

@MaxJPRey
Copy link
Contributor

@akaszynski Regarding the two spaces thing not sure if I did that but I think this is very common practice when learning to type on a standard typewriter. It's engrained into you as part of the instruction, so I doubt I'd ever be able to stop myself from doing it, kind of automatic at this point.

The important thing is that the documentation is consistent. One or two spaces is fine.

@dnwillia-ansys It was already there. I fully agree with you, consistency is the more important. Thanks again for improving the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants