command client list error

[lkarolj]

Hi,
My device is UniFi OS UDM Pro 1.12.30
Source code UniFiSharp v1.5.1
I'm getting an error "Object reference not set to an instance of an object."

unifi-cli.exe interactive url user pwd
UniFi> topology <-- the result of this is correct
UniFi> client list <-- I'm getting an error
UniFi> site list <-- I'm getting an error

UniFi> site list
[*] Getting List of Sites on this Controller
System.NullReferenceException: Object reference not set to an instance of an object.
at IEnumerable UniFiSharp.Json.Attributes.ObjectVisibilityExtensions.GetVisibleProperties(IJsonObject
obj, Levels level) in C:\source\UniFiSharp-master\UniFiSharp\Json\Attributes\ObjectVisibilityExtensions.cs:42
at IRenderable UniFiSharp.CLI.TableGenerator.GenerateMultipleObjectListTable(IEnumerable
data, bool isInsideComplexObject) in C:\source\UniFiSharp-master\UniFiSharp.CLI\TableGenerator.cs:28
at void UniFiSharp.CLI.UniFiSharpCommand1.DrawMultiRowTable<TOutput>(IEnumerable<TOutput> outputs, Levels level) in C:\source\UniFiSharp-master\UniFiSharp.CLI\UniFiSharpCommand.cs:86 at void UniFiSharp.CLI.UniFiSharpCommand1.b__8_0(IEnumerable outputs) in
C:\source\UniFiSharp-master\UniFiSharp.CLI\UniFiSharpCommand.cs:81
at void UniFiSharp.CLI.UniFiSharpCommand1.<>c__DisplayClass7_01.<b__0>d.MoveNext() in
C:\source\UniFiSharp-master\UniFiSharp.CLI\UniFiSharpCommand.cs:77
at void UniFiSharp.CLI.UniFiSharpCommand1.<>c__DisplayClass4_0.<<TryRunning>b__0>d.MoveNext() in C:\source\UniFiSharp-master\UniFiSharp.CLI\UniFiSharpCommand.cs:38 at void Spectre.Console.Status.<>c__DisplayClass16_0.<<StartAsync>b__0>d.MoveNext() in /_/src/Spectre.Console/Live/Status/Status.cs:79 at void Spectre.Console.Status.<>c__DisplayClass17_01.<b__0>d.MoveNext() in
/_/src/Spectre.Console/Live/Status/Status.cs:120
at void Spectre.Console.Progress.<>c__DisplayClass28_01.<<StartAsync>b__0>d.MoveNext() in /_/src/Spectre.Console/Live/Progress/Progress.cs:133 at async Task<T> Spectre.Console.Internal.DefaultExclusivityMode.RunAsync<T>(Func<Task<T>> func) in /_/src/Spectre.Console/Internal/DefaultExclusivityMode.cs:40 at async Task<T> Spectre.Console.Progress.StartAsync<T>(Func<ProgressContext, Task<T>> action) in /_/src/Spectre.Console/Live/Progress/Progress.cs:116 at async Task<T> Spectre.Console.Status.StartAsync<T>(string status, Func<StatusContext, Task<T>> func) in /_/src/Spectre.Console/Live/Status/Status.cs:117 at async Task Spectre.Console.Status.StartAsync(string status, Func<StatusContext, Task> action) in /_/src/Spectre.Console/Live/Status/Status.cs:77 at async Task<int> UniFiSharp.CLI.UniFiSharpCommand1.TryRunning(UniFiSharpSettings settings, Func a) in
C:\source\UniFiSharp-master\UniFiSharp.CLI\UniFiSharpCommand.cs:36

[anthturner]

Possibly related to #31

This ended up being entirely unrelated.

[anthturner]

This appears to be coming from a "failed" cast of the incoming object to IJsonObject, causing the resulting object (which is being dumped to the CLI table) to be NULL, leading to the NullReferenceException.

It's likely that UDM uses a slightly different interface/API, so the existing models are not being populated correctly. However, I don't own or have access to a UDM[-Pro] device to develop or test new code. If someone with a UDM device can help identify and close gaps in the library functionality, I'd be happy to include the enhancements to better support devices from the Dream Machine line.

[lkarolj]

Hi, Thank you for the response. Here is what I found.

data elements have all properties except dpi_stats

This is working: var d is never null
foreach (TEnumerated da in data)
{
var d = da as IJsonObject;
}

This is not working: var d is null
var d = data as IJsonObject

JsonClient
JsonClient._id
JsonClient._is_guest_by_uap
JsonClient._is_guest_by_ugw
JsonClient._is_guest_by_usw
JsonClient._last_seen_by_uap
JsonClient._last_seen_by_ugw
JsonClient._last_seen_by_usw
JsonClient._uptime_by_uap
JsonClient._uptime_by_ugw
JsonClient._uptime_by_usw
JsonClient.ap_mac
JsonClient.assoc_time
JsonClient.authorized
JsonClient.bssid
JsonClient.bytes_r
JsonClient.ccq
JsonClient.channel
JsonClient.essid
JsonClient.first_seen
JsonClient.gw_mac
JsonClient.hostname
JsonClient.idletime
JsonClient.ip
JsonClient.is_guest
JsonClient.is_wired
JsonClient.last_seen
JsonClient.latest_assoc_time
JsonClient.mac
JsonClient.network
JsonClient.network_id
JsonClient.noise
JsonClient.noted
JsonClient.oui
JsonClient.powersave_enabled
JsonClient.qos_policy_applied
JsonClient.radio
JsonClient.radio_proto
JsonClient.rssi
JsonClient.rx_bytes
JsonClient.rx_bytes_r
JsonClient.rx_packets
JsonClient.rx_rate
JsonClient.signal
JsonClient.site_id
JsonClient.sw_depth
JsonClient.sw_mac
JsonClient.sw_port
JsonClient.tx_bytes
JsonClient.tx_bytes_r
JsonClient.tx_packets
JsonClient.tx_power
JsonClient.tx_rate
JsonClient.uptime
JsonClient.user_id
JsonClient.usergroup_id
JsonClient.dpi_stats_last_updated
JsonClient.blocked
JsonClient.fixed_ip
JsonClient.name
JsonClient.use_fixedip
JsonClient.dev_cat
JsonClient.dev_family
JsonClient.dev_id
JsonClient.dev_vendor
JsonClient.os_class
JsonClient.os_name

[anthturner]

Fixed in #33