[Windows] Remove HNSEndpoint only if infra container fails to create#2976
Merged
jianjuns merged 1 commit intoNov 11, 2021
Merged
Conversation
lzhecheng
added
the
area/OS/windows
wenyingd
reviewed
Nov 4, 2021
| @@ -140,7 +140,9 @@ func (ic *ifConfigurator) configureContainerLink( | |||
| containerIface, err := attachContainerLink(endpoint, containerID, containerNetNS, containerIFDev) | |||
Contributor
There was a problem hiding this comment.
If we have check outside the func attachContainerLink, maybe we could remove this check: https://github.com/antrea-io/antrea/blob/main/pkg/agent/cniserver/interface_configuration_windows.go#L302
Codecov Report
@@ Coverage Diff @@
## main #2976 +/- ##
===========================================
+ Coverage 40.23% 60.86% +20.63%
===========================================
Files 166 289 +123
Lines 20693 24540 +3847
===========================================
+ Hits 8326 14937 +6611
+ Misses 11558 7974 -3584
- Partials 809 1629 +820
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lzhecheng
force-pushed
the
win-remove-hnsendpoint-if-infra-container
branch
from
533a0fe to
4ec8d8e
Compare
Contributor
Author
|
/test-all /test-windows-all |
jianjuns
reviewed
Nov 4, 2021
Contributor
jianjuns
left a comment
jianjuns
left a comment
There was a problem hiding this comment.
In the commit message:
there's no need to remove HNSEndpoint if failure
"if failure" -> "at failure" or "if fails to attach the HNS Endpoint"
For non-infra containers, there's no need to remove HNSEndpoint at failure since it will be done when the Pod is removed. Signed-off-by: Zhecheng Li <lzhecheng@vmware.com>
lzhecheng
force-pushed
the
win-remove-hnsendpoint-if-infra-container
branch
from
4ec8d8e to
a135fb5
Compare
Contributor
Author
|
@jianjuns Done. |
Contributor
Author
|
/test-all /test-windows-all |
Contributor
Author
|
/test-windows-e2e /test-e2e /test-windows-networkpolicy |
wenyingd
approved these changes
Nov 10, 2021
jianjuns
approved these changes
Nov 10, 2021
Contributor
Author
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For non-infra containers, there's no need to remove HNSEndpoint if failure since it will be done when the Pod is removed.
Signed-off-by: Zhecheng Li lzhecheng@vmware.com