Fix error handling in Reject implementation#3010
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3010 +/- ##
==========================================
- Coverage 60.94% 59.63% -1.32%
==========================================
Files 292 292
Lines 24708 24710 +2
==========================================
- Hits 15059 14735 -324
- Misses 8006 8384 +378
+ Partials 1643 1591 -52
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
reviewed
Nov 9, 2021
Contributor
antoninbas
left a comment
antoninbas
left a comment
There was a problem hiding this comment.
A better commit message may be:
Fix error handling in Reject implementation
When determining if the packet belongs to Service traffic
Fix error handling in Reject implementation, when determining if the packet belongs to Service traffic. Signed-off-by: wgrayson <wgrayson@vmware.com>
GraysonWu
force-pushed
the
fix-reject-typo
branch
from
1eb6721 to
ae84db4
Compare
antoninbas
approved these changes
Nov 9, 2021
Member
|
/test-all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix error handling in Reject implementation, when determining if the
packet belongs to Service traffic.
Because of the situation described in PR #3006, I didn't notice this
bug before. Fix it in this PR.
Signed-off-by: wgrayson wgrayson@vmware.com