[ExternalNode] Add ExternalNode CRD#3639
Merged
jianjuns merged 1 commit intoApr 20, 2022
Merged
Conversation
Contributor
Author
|
/test-all |
Codecov Report
@@ Coverage Diff @@
## feature/externalnode #3639 +/- ##
========================================================
- Coverage 64.67% 55.70% -8.98%
========================================================
Files 278 392 +114
Lines 39363 54809 +15446
========================================================
+ Hits 25459 30529 +5070
- Misses 11935 21911 +9976
- Partials 1969 2369 +400
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jianjuns
reviewed
Apr 14, 2022
mengdie-song
force-pushed
the
feature-externalnode-crd
branch
from
33060a7 to
28ffb05
Compare
wenyingd
reviewed
Apr 15, 2022
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2021 Antrea Authors | |||
Contributor
There was a problem hiding this comment.
No need to change year?
Contributor
Author
There was a problem hiding this comment.
These files are generated automatically by make codegen so I think the change is expected.
jianjuns
reviewed
Apr 15, 2022
| // +genclient | ||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | ||
|
|
||
| type ExternalNode struct { |
Contributor
There was a problem hiding this comment.
Could you add some comments here?
Contributor
Author
There was a problem hiding this comment.
Thanks Jianjun, I have added a description, could you help take another look?
Contributor
There was a problem hiding this comment.
The current version works for me. Or you can add "bare-metal server" too.
mengdie-song
force-pushed
the
feature-externalnode-crd
branch
from
28ffb05 to
2b3fb5c
Compare
jianjuns
approved these changes
Apr 18, 2022
Contributor
Author
|
/test-windows-all |
Contributor
|
After #3578, we use Helm to generate the YAMLs. You need to re-generate the YAMLs. |
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
mengdie-song
force-pushed
the
feature-externalnode-crd
branch
from
2b3fb5c to
00e425e
Compare
Contributor
Author
|
/test-all |
wenyingd
pushed a commit
that referenced
this pull request
Apr 26, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
wenyingd
pushed a commit
to wenyingd/antrea
that referenced
this pull request
Apr 29, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
wenyingd
pushed a commit
to wenyingd/antrea
that referenced
this pull request
May 7, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
wenyingd
pushed a commit
to wenyingd/antrea
that referenced
this pull request
May 20, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
wenyingd
pushed a commit
to wenyingd/antrea
that referenced
this pull request
May 20, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
wenyingd
pushed a commit
to wenyingd/antrea
that referenced
this pull request
May 26, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
wenyingd
pushed a commit
to wenyingd/antrea
that referenced
this pull request
Jun 1, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
wenyingd
pushed a commit
to wenyingd/antrea
that referenced
this pull request
Jun 1, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
wenyingd
pushed a commit
to wenyingd/antrea
that referenced
this pull request
Jun 9, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
wenyingd
pushed a commit
to wenyingd/antrea
that referenced
this pull request
Jun 27, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
wenyingd
pushed a commit
to wenyingd/antrea
that referenced
this pull request
Jun 28, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
wenyingd
pushed a commit
to wenyingd/antrea
that referenced
this pull request
Jul 12, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
wenyingd
pushed a commit
to wenyingd/antrea
that referenced
this pull request
Jul 27, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
mengdie-song
added a commit
to mengdie-song/antrea
that referenced
this pull request
Aug 3, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
mengdie-song
added a commit
to mengdie-song/antrea
that referenced
this pull request
Aug 3, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
mengdie-song
added a commit
to mengdie-song/antrea
that referenced
this pull request
Aug 8, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
mengdie-song
added a commit
to mengdie-song/antrea
that referenced
this pull request
Aug 8, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
mengdie-song
added a commit
to mengdie-song/antrea
that referenced
this pull request
Aug 8, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
wenyingd
pushed a commit
to wenyingd/antrea
that referenced
this pull request
Aug 10, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
wenyingd
pushed a commit
to wenyingd/antrea
that referenced
this pull request
Aug 11, 2022
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
This change adds API definition for ExternalNode CRD and generates the corresponding client and yaml files. Signed-off-by: Mengdie Song <songm@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds API definition for ExternalNode CRD
and generates the corresponding client and yaml files.
Signed-off-by: Mengdie Song songm@vmware.com