Add support for containerd to antrea-eks-node-init.yml#3840
Merged
antoninbas merged 1 commit intoMay 31, 2022
Conversation
Contributor
Author
|
I'm going to run the cloud CI on my branch for testing |
Codecov Report
@@ Coverage Diff @@
## main #3840 +/- ##
=======================================
Coverage 47.70% 47.70%
=======================================
Files 256 256
Lines 37092 37092
=======================================
Hits 17693 17693
Misses 17673 17673
Partials 1726 1726
Flags with carried forward coverage won't be shown. Click here to find out more. |
jianjuns
reviewed
May 28, 2022
tnqn
added
the
action/release-note
tnqn
previously approved these changes
May 30, 2022
Member
tnqn
left a comment
tnqn
left a comment
There was a problem hiding this comment.
LGTM, a type in commit message: ensuire
Contributor
Author
|
/skip-all |
antoninbas
force-pushed
the
support-containerd-for-eks-clusters
branch
from
ebc43e4 to
d8f3572
Compare
Containerd is available as an alternative to docker since EKS v1.21. Starting with EKS v1.23, containerd will also be the default container runtime. Currently antrea-eks-node-init.yml assumes that docker is always the container runtime, which means that Antrea cannot be run on EKS clusters using containerd. We fix this by adding support for containerd. We also make a couple of improvements to the startup script in antrea-eks-node-init.yml, to ensure that it can be run again if the contents of the script change, which is useful for testing and may also be useful to roll out patches. Finally, we update our EKS CI to test with containerd instead of docker, since containerd will be the default soon. Fixes antrea-io#3471 Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas
force-pushed
the
support-containerd-for-eks-clusters
branch
from
d8f3572 to
f82f51e
Compare
Contributor
Author
Contributor
Author
|
/skip-all |
jianjuns
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Containerd is available as an alternative to docker since EKS
v1.21. Starting with EKS v1.23, containerd will also be the default
container runtime. Currently antrea-eks-node-init.yml assumes that
docker is always the container runtime, which means that Antrea cannot
be run on EKS clusters using containerd. We fix this by adding support
for containerd.
We also make a couple of improvements to the startup script in
antrea-eks-node-init.yml, to ensure that it can be run again if the
contents of the script change, which is useful for testing and may
also be useful to roll out patches.
Finally, we update our EKS CI to test with containerd instead of docker,
since containerd will be the default soon.
Fixes #3471
Signed-off-by: Antonin Bas abas@vmware.com