Fix leak in resourceimport_controller.go#4251
Merged
Merged
Conversation
Dyanngg
added
kind/bug
Codecov Report
@@ Coverage Diff @@
## main #4251 +/- ##
==========================================
+ Coverage 63.16% 63.69% +0.53%
==========================================
Files 388 400 +12
Lines 55147 55215 +68
==========================================
+ Hits 34833 35170 +337
+ Misses 17766 17458 -308
- Partials 2548 2587 +39
|
luolanzone
reviewed
Sep 28, 2022
Dyanngg
force-pushed
the
fix-installed-imports-leak
branch
from
1d4ed7f to
c3c4c4f
Compare
luolanzone
reviewed
Sep 29, 2022
tnqn
reviewed
Sep 29, 2022
Dyanngg
force-pushed
the
fix-installed-imports-leak
branch
from
c3c4c4f to
af9f381
Compare
luolanzone
reviewed
Sep 30, 2022
Dyanngg
force-pushed
the
fix-installed-imports-leak
branch
from
af9f381 to
4f68a1d
Compare
The ResourceImport reconciler only adds/updates installed ResourceImports to the installedResImports cache, but never removes them when they are deleted from the K8s API and all corresponding resources are deleted successfully. This PR fixes the above issue. Signed-off-by: Dyanngg <dingyang@vmware.com>
Dyanngg
force-pushed
the
fix-installed-imports-leak
branch
from
4f68a1d to
bd7b407
Compare
Contributor
Author
|
/test-all |
tnqn
approved these changes
Oct 17, 2022
Member
|
/test-multicluster-e2e |
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
The ResourceImport reconciler only adds/updates installed ResourceImports to the installedResImports cache, but never removes them when they are deleted from the K8s API and all corresponding resources are deleted successfully. This PR fixes the above issue. Signed-off-by: Dyanngg <dingyang@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ResourceImport reconciler only adds/updates installed ResourceImports to the installedResImports cache, but never removes them when they are deleted from the K8s API and all corresponding resources are deleted successfully. This PR fixes the above issue.
Signed-off-by: Dyanngg dingyang@vmware.com