Add validations for NodeNetworkPolicy#6613
Merged
Merged
Conversation
rajnkamr
reviewed
Aug 19, 2024
tnqn
reviewed
Aug 19, 2024
tnqn
previously approved these changes
Aug 19, 2024
Member
tnqn
left a comment
tnqn
left a comment
There was a problem hiding this comment.
LGTM
@hongliangl could you also take a look?
rajnkamr
added
action/release-note
Prevent ACNP appliedTo Node (NodeNetworkPolicy) with "enableLogging: true". Prevent ACNP appliedTo Node (NodeNetworkPolicy) with other selectors. For antrea-io#6525 Signed-off-by: Kumar Atish <kumar.atish@broadcom.com>
Member
|
/skip-all |
1 similar comment
Member
|
/skip-all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent ACNP appliedTo Node (NodeNetworkPolicy) with "enableLogging: true".
Prevent ACNP appliedTo Node (NodeNetworkPolicy) with other selectors.
For #6525