Add Except for Antrea-native ipBlock#6658
Merged
Merged
Conversation
Dyanngg
force-pushed
the
add-ipblock-except-antrea
branch
4 times, most recently
from
c840536 to
cd59fed
Compare
Dyanngg
changed the title
Dyanngg
force-pushed
the
add-ipblock-except-antrea
branch
2 times, most recently
from
cc5df40 to
1153d8c
Compare
antoninbas
reviewed
Sep 11, 2024
Dyanngg
force-pushed
the
add-ipblock-except-antrea
branch
from
1153d8c to
413edae
Compare
antoninbas
added
action/release-note
antoninbas
reviewed
Sep 23, 2024
Comment on lines
+759
to
+761
| if ipb.CIDR == "" { | ||
| return "field 'cidr' is required in an ipBlock", false | ||
| } |
Contributor
There was a problem hiding this comment.
We can keep this, but I assume this is guaranteed by the OpenAPI spec?
Contributor
Author
There was a problem hiding this comment.
Yes it should already be guaranteed by openAPI, just trying to keep it on par with https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/networking/validation/validation.go#L219
Signed-off-by: Dyanngg <dingyang@vmware.com>
Signed-off-by: Dyanngg <dingyang@vmware.com>
Dyanngg
force-pushed
the
add-ipblock-except-antrea
branch
from
413edae to
1a0c157
Compare
tnqn
reviewed
Sep 27, 2024
Comment on lines
+1078
to
+1080
| if multicast && unicast { | ||
| return "can not set multicast groupAddress together with unicast ip address", false | ||
| } |
Member
There was a problem hiding this comment.
Will multicast NetworkPolicy support the except field?
Contributor
Author
There was a problem hiding this comment.
This is obviously not supported for IGMP rules since the addresses you would specify in the protocol is not a CIDR to begin with. In terms of "dropping udp egress to a multicast CIDR", I would say yes, since the CIDR subtraction logic will be the same for regular and multicast IP addresses
Contributor
Author
|
/test-all |
Contributor
|
/test-conformance |
Contributor
Author
|
/test-networkpolicy /test-e2e /test-all-features-conformance |
tnqn
approved these changes
Oct 9, 2024
Contributor
Author
|
/test-conformance |
Contributor
|
/test-kind-e2e |
Contributor
|
|
hangyan
pushed a commit
to hangyan/antrea
that referenced
this pull request
Oct 29, 2024
Fixes antrea-io#6428 This PR adds an "except" field for all ipBlocks in Antrea-native policies and groups. Users can exclude certain CIDRs from the ipBlock.cidr in all resources that support ipBlocks, including AntreaClusterNetworkPolicy, AntreaNetworkPolicy, ClusterGroup and Group. Group membership and IP association query logic are also updated to accommodate this change. Documentation will follow in a separate PR. Signed-off-by: Dyanngg <dingyang@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6428
This PR adds an "except" field for all ipBlocks in Antrea-native policies and groups. Users can exclude certain CIDRs from the ipBlock.cidr in all resources that support ipBlocks, including AntreaClusterNetworkPolicy, AntreaNetworkPolicy, ClusterGroup and Group. Group membership and IP association query logic are also updated to accommodate this change. Documentation will follow in a separate PR.