Skip to content

Add integration test for External Node#37

Merged
Anandkumar26 merged 1 commit into
mainfrom
externalnode_test
Oct 17, 2022
Merged

Add integration test for External Node#37
Anandkumar26 merged 1 commit into
mainfrom
externalnode_test

Conversation

@archanapholla
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread test/integration/externalnode_test.go
Comment thread test/integration/externalnode_test.go Outdated
Comment thread test/utils/cloud_provider_aws.go
@archanapholla archanapholla force-pushed the externalnode_test branch 2 times, most recently from 2008c1d to c92346a Compare October 11, 2022 04:39
Comment thread go.mod Outdated
Comment thread test/integration/externalnode_test.go
Comment thread test/integration/externalnode_test.go Outdated
Comment thread test/integration/externalnode_test.go
Comment thread test/integration/externalnode_test.go Outdated
Comment thread test/integration/externalnode_test.go
Comment thread test/integration/externalnode_test.go Outdated
Comment thread test/integration/integration_suite_test.go Outdated
Comment thread test/integration/externalnode_test.go Outdated
Comment thread test/integration/externalnode_test.go
Comment thread test/integration/externalnode_test.go Outdated
Comment thread test/integration/externalnode_test.go Outdated
Comment thread test/integration/externalnode_test.go
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 12, 2022

Codecov Report

Merging #37 (52a343c) into main (0f113bb) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   50.27%   50.15%   -0.13%     
==========================================
  Files          45       45              
  Lines        6993     6993              
==========================================
- Hits         3516     3507       -9     
- Misses       3093     3102       +9     
  Partials      384      384              
Flag Coverage Δ
unit-tests 50.15% <ø> (-0.13%) ⬇️
Impacted Files Coverage Δ
pkg/cloud-provider/cloudapi/aws/aws_ec2.go 46.47% <0.00%> (-1.41%) ⬇️
pkg/controllers/cloud/networkpolicy.go 69.23% <0.00%> (-0.58%) ⬇️

Signed-off-by: Archana Holla <harchana@vmware.com>
Copy link
Copy Markdown
Contributor

@reachjainrahul reachjainrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM
@Anandkumar26 Merge the changes if you are comfortable too.

@reachjainrahul
Copy link
Copy Markdown
Contributor

/nephe-test-e2e-all

@reachjainrahul
Copy link
Copy Markdown
Contributor

/nephe-test-e2e-aks

1 similar comment
@reachjainrahul
Copy link
Copy Markdown
Contributor

/nephe-test-e2e-aks

Copy link
Copy Markdown
Contributor

@Anandkumar26 Anandkumar26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

nephe-test-e2e-aks - failed, which is not related to this PR.
Applied NetworkPolicy to VirtualMachine by kind label selector using group
failed to poll policies [test-cloud-setup-anp test-cloud-anp] for resources [ubuntu-host-ci-vmlinux-0-14148]: timed out waiting for the condition

@Anandkumar26 Anandkumar26 merged commit 33a7273 into main Oct 17, 2022
@reachjainrahul reachjainrahul deleted the externalnode_test branch October 27, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants