Skip to content

refactor: use umi winPath to deal with path #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from
+4 −5
Open

refactor: use umi winPath to deal with path #281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57961eb
refactor: use umi winPath to deal with path
sunsunmonkey Feb 4, 2024
41ffdf5
refactor: change the position for import
sunsunmonkey Feb 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/plugin/examples.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import fm from 'front-matter';
import { winPath } from 'dumi/plugin-utils';
import * as fs from 'fs-extra';
import * as glob from 'glob';
import * as path from 'path';
Expand Down Expand Up @@ -48,11 +49,9 @@ const getExampleDemos = (exampleDir: string) => {
* @author YuZhanglong <[email protected]>
*/
const getTopicExamples = (topicPath: string, showAPIDoc: boolean) => {
const examplePaths = glob
.sync(`${topicPath.replace(/\\/g, '/')}/*`)
.filter((item) => {
return !item.endsWith('.js');
});
const examplePaths = glob.sync(`${winPath(topicPath)}/*`).filter((item) => {
Copy link
Member

@hustcc hustcc Feb 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

启动测试过的吧？

Copy link
Contributor Author

@sunsunmonkey sunsunmonkey Feb 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯，他本身其实是一样的

return !item.endsWith('.js');
});

return examplePaths
.map((item) => {
Expand Down