Set grpc.http2.min_ping_interval_without_data_ms to 5s to avoid too_many_pings#6
Open
jmthomas wants to merge 1 commit intoanycable:mainfrom
Open
Set grpc.http2.min_ping_interval_without_data_ms to 5s to avoid too_many_pings#6jmthomas wants to merge 1 commit intoanycable:mainfrom
jmthomas wants to merge 1 commit intoanycable:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per https://github.com/grpc/grpc/blob/master/doc/keepalive.md and grpc/grpc#25713 it is tricky to get the keep alive ping setting correct. In our own application using anycable I've seen the following errors:
This seemed to have improved over time so I don't know if some of the settings have changed but I think it is still incorrect. Based on a lot of reading it appears the server minimum has to be strictly lower than the client interval or jitter produces strikes. You had them set exactly the same. Since the client is hard coded to 10 I set the server to 5.
More information is available here: https://github.com/grpc/proposal/blob/master/A8-client-side-keepalive.md
Also I remove the key that had no effect. The key that matters is
grpc.http2.min_ping_interval_without_data_msas documented here: https://grpc.github.io/grpc/core/group__grpc__arg__keys.html