JS-9749: image loader fixes for chat attachments and editor image block#2211
Merged
Conversation
…lapse - Chat attachment now shows the standard <Loader> while the gateway image is in flight, mirroring the editor image block pattern. - Editor image block: when widthInPixels/heightInPixels are known but the user hasn't resized (no block.fields.width), reserve the wrap with the natural pixel width so aspect-ratio can compute height. The inline-block wrap was previously collapsing to 0×0 during load (introduced by JS-9425), hiding the loader entirely. - Loader overlay sits centered on a themed light-grey background with rounded corners while loading; vanishes on onLoad.
ra3orblade
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<Loader>while the gateway request is in flight, mirroring the editor image block pattern.display: inline-block+ onlyaspect-ratio(no width) cannot resolve dimensions, so the loader had no area to render in. Now the wrap is reserved with the naturalwidthInPixels(capped bymax-width: 100%) when no user-set width is present.--color-shape-highlight-light) with rounded corners while loading, and vanishes the momentonLoadfires.Retry/reload behavior on failed loads is intentionally out of scope and will land in a separate PR.
Test plan
rgba(255,255,255,0.03)).