Skip to content

core, repair: migrate tests to non-overlapping ports #7141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 28, 2025

Conversation

puhtaytow
Copy link

Problem

A bunch of tests still relies on either hardcoded ports or bind_to_localhost and bind_to_unspecified. This creates flaky tests in cases where unique port ranges are needed.

This PR is the step in the journey toward resolving the issue.

Related to #7055

Summary of Changes

  • Fixed bug with inclusive end port in test_request_repair_for_shred_from_address
  • Migrated instances across core, repair tests that had in place obsolete bind_to_unspecified

@mergify mergify bot requested a review from a team July 24, 2025 15:31
@0xbrw
Copy link

0xbrw commented Jul 25, 2025

thank you keeping the PRs small and easy to review! we'll have @alexpyattaev or @KirillLykov take a look when they get a chance

@alexpyattaev alexpyattaev added the CI Pull Request is ready to enter CI label Jul 25, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Jul 25, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (86d14f6) to head (776f857).
⚠️ Report is 29 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7141   +/-   ##
=======================================
  Coverage    83.2%    83.2%           
=======================================
  Files         853      853           
  Lines      373926   373929    +3     
=======================================
+ Hits       311358   311422   +64     
+ Misses      62568    62507   -61     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puhtaytow
Copy link
Author

puhtaytow commented Jul 26, 2025

thank you keeping the PRs small and easy to review! we'll have @alexpyattaev or @KirillLykov take a look when they get a chance

thank you 🙏

Copy link

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexpyattaev alexpyattaev merged commit edc8ac6 into anza-xyz:master Jul 28, 2025
43 checks passed
@puhtaytow puhtaytow deleted the core-repair-service-tests-0 branch July 29, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants