-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Param argument accepts generic dict subtypes #29782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
overall lgtm, though you've to add supported test cases for this. Also, could you ensure you've tested all paths touched by this change, like DAG trigger with config via UI/API/CLI, dag test cmd, etc. |
I wasn't sure about a test case given this is a typing change, so |
1aa49bf
to
4ab90c3
Compare
Yeah. I kinda agree that no tests are needed in this case. |
rebased to rebuild with latest main |
@msumit - wdyt? |
4ab90c3
to
71e5e56
Compare
Awesome work, congrats on your first merged pull request! |
(cherry picked from commit b069df9)
closes: #29358
Allow subtypes of
dict
to be passed as the DAG and taskparams
argument. This ensures that aParamsDict
object is a valid type for the argument value.Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.