[v3-2-test] Upgrade to Vite 8. (#65084)#65166
Merged
Conversation
tirkarthi
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
Merged
bbovenzi
approved these changes
Apr 13, 2026
pierrejeambrun
approved these changes
Apr 14, 2026
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Looks good but static checks need fixing.
tirkarthi
force-pushed
the
backport-bcd31b2-v3-2-test
branch
from
6273bcd to
9f225da
Compare
Contributor
Author
|
Looks like msw is upgraded to 2.13.x from 2.12.x which could be causing the error. This was not upgraded in main during vite 8 upgrade so not sure why backport tries to install 2.13.x . |
vatsrahul1001
force-pushed
the
v3-2-test
branch
from
b7b4ac6 to
f0ad43b
Compare
vatsrahul1001
requested review from
RNHTTR,
amoghrajesh,
ashb,
bugraoz93,
dabla,
ephraimbuddy,
gopidesupavan,
hussein-awala,
jason810496,
jedcunningham,
josh-fell,
jscheffl,
kaxil,
potiuk,
shahar1 and
vincbeck
as code owners
vatsrahul1001
requested review from
Fokko,
Lee-W,
XD-DENG,
dheerajturaga,
mobuchowski,
o-nikolas,
rawwar and
uranusjr
as code owners
vatsrahul1001
force-pushed
the
v3-2-test
branch
from
28a8ef5 to
18a3932
Compare
vatsrahul1001
force-pushed
the
v3-2-test
branch
from
f7c41f9 to
5560e7c
Compare
tirkarthi
force-pushed
the
backport-bcd31b2-v3-2-test
branch
from
ea85bcc to
a8a13c4
Compare
vatsrahul1001
force-pushed
the
v3-2-test
branch
from
376e74f to
085504d
Compare
vatsrahul1001
force-pushed
the
v3-2-test
branch
from
075c4fc to
3fe9a9a
Compare
vatsrahul1001
force-pushed
the
backport-bcd31b2-v3-2-test
branch
from
62caae8 to
653eff8
Compare
potiuk
force-pushed
the
backport-bcd31b2-v3-2-test
branch
from
653eff8 to
97fd2dc
Compare
potiuk
added a commit
that referenced
this pull request
Apr 27, 2026
The dependabot bump in this PR brings in newer typescript-eslint and msw versions that produce TS errors and lint diffs against the existing v3-2-test code: * eslint with @typescript-eslint v8 flags several `as X` casts as redundant — auto-fix removes them, and two of the now-unused symbols (`ColorMode` type alias, `ParamsSpec` import) need follow-up cleanup. * The msw `SetupServerApi` type lost the `#private` and `network` members; the existing `let server: SetupServerApi` declaration no longer accepts the value returned by `setupServer(...)`. Same fix as PR #65166 — drop the annotation, let TypeScript infer.
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 27, 2026
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 27, 2026
The dependabot bump in this PR brings in newer typescript-eslint and msw versions that produce TS errors and lint diffs against the existing v3-2-test code: * eslint with @typescript-eslint v8 flags several `as X` casts as redundant — auto-fix removes them, and two of the now-unused symbols (`ColorMode` type alias, `ParamsSpec` import) need follow-up cleanup. * The msw `SetupServerApi` type lost the `#private` and `network` members; the existing `let server: SetupServerApi` declaration no longer accepts the value returned by `setupServer(...)`. Same fix as PR #65166 — drop the annotation, let TypeScript infer.
Contributor
Author
|
Thanks @potiuk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to Vite 8.
Update vite.config.ts for plugin-react@6.0.0.
cherry picked from commit bcd31b2
Was generative AI tooling used to co-author this PR?
No