-
Notifications
You must be signed in to change notification settings - Fork 368
feat: gatewayproxy controller #2444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3415075
feat: Add GatewayProxy controller and related functionality
dspo caeb601
Merge remote-tracking branch 'origin/master' into feat/gatewayproxy-c…
dspo b76798f
fix: Update error package import
dspo 9a89a74
refactor: Remove redundant GatewayProxy indexer and update Service in…
dspo cc63c55
add e2e test
dspo 3b3a415
Add Apache license header to gatewayproxy_controller.go
dspo 2208179
resolve comments
dspo b748ea3
resolve comments
dspo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| package controller | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
|
|
||
| "github.com/go-logr/logr" | ||
| corev1 "k8s.io/api/core/v1" | ||
| discoveryv1 "k8s.io/api/discovery/v1" | ||
| networkingv1 "k8s.io/api/networking/v1" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/handler" | ||
| "sigs.k8s.io/controller-runtime/pkg/reconcile" | ||
| v1 "sigs.k8s.io/gateway-api/apis/v1" | ||
ronething marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| "github.com/apache/apisix-ingress-controller/api/v1alpha1" | ||
| "github.com/apache/apisix-ingress-controller/internal/controller/indexer" | ||
| "github.com/apache/apisix-ingress-controller/internal/provider" | ||
| "github.com/apache/apisix-ingress-controller/internal/utils" | ||
| ) | ||
|
|
||
| // GatewayProxyController reconciles a GatewayProxy object. | ||
| type GatewayProxyController struct { | ||
| client.Client | ||
|
|
||
| Scheme *runtime.Scheme | ||
| Log logr.Logger | ||
| Provider provider.Provider | ||
| } | ||
|
|
||
| func (r *GatewayProxyController) SetupWithManager(mrg ctrl.Manager) error { | ||
| return ctrl.NewControllerManagedBy(mrg). | ||
| For(&v1alpha1.GatewayProxy{}). | ||
| Watches(&corev1.Service{}, | ||
| handler.EnqueueRequestsFromMapFunc(r.listGatewayProxiesForProviderService), | ||
| ). | ||
| Watches(&discoveryv1.EndpointSlice{}, | ||
| handler.EnqueueRequestsFromMapFunc(r.listGatewayProxiesForProviderEndpointSlice), | ||
| ). | ||
| Watches(&corev1.Secret{}, | ||
| handler.EnqueueRequestsFromMapFunc(r.listGatewayProxiesForSecret), | ||
| ). | ||
| Complete(r) | ||
| } | ||
|
|
||
| func (r *GatewayProxyController) Reconcile(ctx context.Context, req ctrl.Request) (reconcile.Result, error) { | ||
| var gp v1alpha1.GatewayProxy | ||
| if err := r.Get(ctx, req.NamespacedName, &gp); err != nil { | ||
AlinsRan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return ctrl.Result{}, client.IgnoreNotFound(err) | ||
| } | ||
|
|
||
| var tctx = provider.NewDefaultTranslateContext(ctx) | ||
|
|
||
| // if there is no provider, update with empty translate context | ||
| if gp.Spec.Provider == nil || gp.Spec.Provider.ControlPlane == nil { | ||
| return reconcile.Result{}, r.Provider.Update(ctx, tctx, &gp) | ||
| } | ||
|
|
||
| // process endpoints for provider service | ||
| providerService := gp.Spec.Provider.ControlPlane.Service | ||
| if providerService == nil { | ||
| tctx.EndpointSlices[req.NamespacedName] = nil | ||
| } else { | ||
| if err := addProviderEndpointsToTranslateContext(tctx, r.Client, types.NamespacedName{ | ||
| Namespace: gp.Namespace, | ||
| Name: providerService.Name, | ||
| }); err != nil { | ||
| return reconcile.Result{}, err | ||
| } | ||
| } | ||
|
|
||
| // process secret for provider auth | ||
| auth := gp.Spec.Provider.ControlPlane.Auth | ||
| if auth.AdminKey != nil && auth.AdminKey.ValueFrom != nil && auth.AdminKey.ValueFrom.SecretKeyRef != nil { | ||
| var ( | ||
| secret corev1.Secret | ||
| secretNN = types.NamespacedName{ | ||
| Namespace: gp.GetNamespace(), | ||
| Name: auth.AdminKey.ValueFrom.SecretKeyRef.Name, | ||
| } | ||
| ) | ||
| if err := r.Get(ctx, secretNN, &secret); err != nil { | ||
| r.Log.Error(err, "failed to get secret", "secret", secretNN) | ||
| return reconcile.Result{}, err | ||
| } | ||
| tctx.Secrets[secretNN] = &secret | ||
| } | ||
|
|
||
| // list Gateways that reference the GatewayProxy | ||
| var ( | ||
| gatewayList v1.GatewayList | ||
| ingressClassList networkingv1.IngressClassList | ||
| indexKey = indexer.GenIndexKey(gp.GetNamespace(), gp.GetName()) | ||
| ) | ||
| if err := r.List(ctx, &gatewayList, client.MatchingFields{indexer.ParametersRef: indexKey}); err != nil { | ||
| r.Log.Error(err, "failed to list GatewayList") | ||
| return ctrl.Result{}, nil | ||
| } | ||
|
|
||
| // list IngressClasses that reference the GatewayProxy | ||
| if err := r.List(ctx, &ingressClassList, client.MatchingFields{indexer.IngressClassParametersRef: indexKey}); err != nil { | ||
| r.Log.Error(err, "failed to list GatewayList") | ||
ronething marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| return reconcile.Result{}, err | ||
| } | ||
|
|
||
| // append referrers to tanslate context | ||
ronething marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| for _, item := range gatewayList.Items { | ||
| tctx.GatewayProxyReferrers[req.NamespacedName] = append(tctx.GatewayProxyReferrers[req.NamespacedName], utils.NamespacedNameKind(&item)) | ||
| } | ||
| for _, item := range ingressClassList.Items { | ||
| tctx.GatewayProxyReferrers[req.NamespacedName] = append(tctx.GatewayProxyReferrers[req.NamespacedName], utils.NamespacedNameKind(&item)) | ||
| } | ||
|
|
||
| if err := r.Provider.Update(ctx, tctx, &gp); err != nil { | ||
| return reconcile.Result{}, err | ||
| } | ||
|
|
||
| return reconcile.Result{}, nil | ||
| } | ||
|
|
||
| func (r *GatewayProxyController) listGatewayProxiesForProviderService(ctx context.Context, obj client.Object) (requests []reconcile.Request) { | ||
| service, ok := obj.(*corev1.Service) | ||
| if !ok { | ||
| r.Log.Error(errors.New("unexpected object type"), "failed to convert object to Service") | ||
| return nil | ||
| } | ||
|
|
||
| return ListRequests(ctx, r.Client, r.Log, &v1alpha1.GatewayProxyList{}, client.MatchingFields{ | ||
| indexer.ServiceIndexRef: indexer.GenIndexKey(service.GetNamespace(), service.GetName()), | ||
| }) | ||
| } | ||
|
|
||
| func (r *GatewayProxyController) listGatewayProxiesForProviderEndpointSlice(ctx context.Context, obj client.Object) (requests []reconcile.Request) { | ||
| endpointSlice, ok := obj.(*discoveryv1.EndpointSlice) | ||
| if !ok { | ||
| r.Log.Error(errors.New("unexpected object type"), "failed to convert object to EndpointSlice") | ||
| return nil | ||
| } | ||
|
|
||
| return ListRequests(ctx, r.Client, r.Log, &v1alpha1.GatewayProxyList{}, client.MatchingFields{ | ||
| indexer.ServiceIndexRef: indexer.GenIndexKey(endpointSlice.GetNamespace(), endpointSlice.Labels[discoveryv1.LabelServiceName]), | ||
| }) | ||
| } | ||
|
|
||
| func (r *GatewayProxyController) listGatewayProxiesForSecret(ctx context.Context, object client.Object) []reconcile.Request { | ||
| secret, ok := object.(*corev1.Secret) | ||
| if !ok { | ||
| r.Log.Error(errors.New("unexpected object type"), "failed to convert object to Secret") | ||
| return nil | ||
| } | ||
| return ListRequests(ctx, r.Client, r.Log, &v1alpha1.GatewayProxyList{}, client.MatchingFields{ | ||
| indexer.SecretIndexRef: indexer.GenIndexKey(secret.GetNamespace(), secret.GetName()), | ||
| }) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.