-
Notifications
You must be signed in to change notification settings - Fork 127
feat(c/driver): add support for CMake packages of Go based drivers #2561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
@m-kuhn, does vcpkg pick these up correctly?
This looks good @lidavidm, I guess it will be picked up I had troubles with the Go based drivers actually, as they would trigger a build process with another compiler which was not available (more precisely: when building with MSVC it would try to build things with gcc). I didn't follow up with this yet and postponed this to later, as I don't have an urgent need for this. |
The CGo builds require GCC, basically. They won't work with MSVC. #634 |
I'm wondering if clang for Windows can get around this but Microsoft stopped offering developer VMs and so I have no way of trying it out |
Ideally the build system would be passed from the cmake environment to the go build so we would reuse same compiler (and flags etc). @lidavidm hint: if you want a (cli only) windows, you could use a windows github action runner and connect via ssh with https://github.com/mxschmitt/action-tmate |
That is the problem here: CGo is being told to invoke MSVC, and it is dutifully doing that, but CGo only supports GCC and so it breaks down. (golang/go#20982) Apparently clang for Windows also doesn't work: golang/go#17014 |
So I think these targets can't be exposed on Windows unless/until Google fixes this. |
Oh, I see. |
Fixes #2506.