[Parquet] route dictionary page through the PageStore#10142
Open
liamzwbao wants to merge 2 commits into
Open
Conversation
Contributor
Author
adriangb
approved these changes
Jun 16, 2026
adriangb
left a comment
adriangb
left a comment
Contributor
There was a problem hiding this comment.
Very nice! I wonder if we could update any of the existing tests to show even lower memory usage?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This addresses step B of #10062: make the store handle dictionary page the same way as data pages.
What changes are included in this PR?
dictionary: Vec<Bytes>field with a trackeddictionary_key: Option<PageKey>(plusdictionary_len). The dictionary page is now put into the PageStore like any other page; only its handle is held apart so it can be taken back first at splice.StreamingColumnChunkReadernow drains every page (dictionary first, then data) from the store.Are these changes tested?
Yes, also a new test added to ensure dict page is in page store
Are there any user-facing changes?
No