Add Parquet arrow_reader benchmarks for {u}int{8,16} columns
#7484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
arrow_reader benchmarks for {u}int{8,16} columns
alamb
commented
May 8, 2025
| @@ -1307,6 +1386,17 @@ fn add_benches(c: &mut Criterion) { | |||
| ); | |||
| group.finish(); | |||
|
|
|||
| // primitive int64 / logical uint64 benchmarks | |||
| let mut group = c.benchmark_group("arrow_array_reader/UInt64Array"); | |||
| bench_primitive::<Int64Type>( | |||
There was a problem hiding this comment.
I was confused at first -- I thought this is meant to be
Suggested change
| bench_primitive::<Int64Type>( | |
| bench_primitive::<UInt64Type>( |
However, the type is the parquet type not the arrow / logical type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I would like to easily compare the performance of the changes in #7055 to main. My scripts rely on the benchmark being present on main
What changes are included in this PR?
Bring the benchmarks @etseidl wrote in #7055 into a separate PR
Are there any user-facing changes?