-
Notifications
You must be signed in to change notification settings - Fork 959
Optimize coalesce kernel for StringViewArray
(5-10%)
#7620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 |
🤖: Benchmark completed Details
|
I did't realize @Dandandan has done basically the same thing in #7614, so let's go with that one |
Which issue does this PR close?
coalesce
andconcat
for views #7615coalesce
kernel andBatchCoalescer
for statefully combining selected b…atches: #7597Rationale for this change
@Dandandan and @zhuqi-lucas pointed out some places we could improve gc_string_view on #7597, so let's do that
What changes are included in this PR?
Avoid allocations and re-validating RecordBatch schema
Are there any user-facing changes?
Faster performance (these are the larger string benchmarks added in #7619):