pyarrow: Wrap capsule extraction errors into an explicit error#9660
Open
Tpt wants to merge 4 commits into
Open
pyarrow: Wrap capsule extraction errors into an explicit error#9660Tpt wants to merge 4 commits into
Tpt wants to merge 4 commits into
Conversation
Tpt
force-pushed
the
tpt/pyarrow-capsule
branch
2 times, most recently
from
aa910ff to
61391e3
Compare
Contributor
Author
|
@alamb Thank you for the rebase. This MR is blocked by a segfault. I have not understood why yet and put this MR on hold to go back to it with a fresh mind. I will try to debug that in the next few days. Sorry for having it been stalled for so long. Update: got it working, there was a use-after-free error. |
Tpt
force-pushed
the
tpt/pyarrow-capsule
branch
from
f0b61da to
7ecba54
Compare
Tpt
force-pushed
the
tpt/pyarrow-capsule
branch
from
b1880b6 to
240fd32
Compare
Remove validate_pycapsule: pointer_checked already raises an exception if the capsule type is wrong, and we wrap it into a nicer error
Contributor
Author
|
@timsaucer I would love to get some review on this MR. It cleans up both code and error messages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove validate_pycapsule: pointer_checked already raises an exception if the capsule type is wrong, and we wrap it into a nicer error
Also relies on a trait to associate types with their capsules names
Because we wrap the exception (equivalent of
raise X from Y), the original exception is still thereFollow up of #9639 #9594