Skip to content

GH-33696: [CI][Python] Fix nightly CI for timestamp failure in pandas dev build #33730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Jan 17, 2023

The behaviour change in pandas will likely be reverted (pandas-dev/pandas#49076), so temporarily fixing this test to get green CI.

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #33696 has been automatically assigned in GitHub to PR creator.

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.8-pandas-nightly test-conda-python-3.9-pandas-upstream_devel

@github-actions
Copy link

Revision: d9bbfe7

Submitted crossbow builds: ursacomputing/crossbow @ actions-2809e9f0c8

Task Status
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.9-pandas-upstream_devel Github Actions

@danepitkin
Copy link
Member

Do we abandon this now that the pandas fix has been merged? pandas-dev/pandas#49076

@cpcloud cpcloud closed this Mar 30, 2023
@jorisvandenbossche
Copy link
Member Author

Indeed, this specific fix to CI is no longer needed to have the build passing. We probably should still stop using the attribute though (both in the tests as in the code). Will open a separate issue about this.

@jorisvandenbossche jorisvandenbossche deleted the gh-33696-pandas-timestamp branch March 31, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI][Python] Nightlies pandas jobs with pandas nightly and upstream_devel are currently failing
3 participants