Skip to content

keep session info in RedisConnContext#2902

Merged
wwbmmm merged 5 commits intoapache:masterfrom
lintanghui:master
Mar 6, 2025
Merged

keep session info in RedisConnContext#2902
wwbmmm merged 5 commits intoapache:masterfrom
lintanghui:master

Conversation

@lintanghui
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: #2901

Problem Summary: RedisConnContext 添加auth信息支持多租户场景

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响): 无

  • Breaking backward compatibility(向后兼容性): 兼容


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm
Copy link
Copy Markdown
Contributor

wwbmmm commented Feb 28, 2025

另外,建议补充相关的单元测试

@lintanghui
Copy link
Copy Markdown
Contributor Author

另外,建议补充相关的单元测试

ctx 添加session只是方便用户添加一些wrap 本身在redis层面不太好进行测试,只要保证原来的redis 单测是兼容的即可

@wwbmmm
Copy link
Copy Markdown
Contributor

wwbmmm commented Mar 3, 2025

另外,建议补充相关的单元测试

ctx 添加session只是方便用户添加一些wrap 本身在redis层面不太好进行测试,只要保证原来的redis 单测是兼容的即可

单测只要验证ctx能够传到用户自定义的RedisCommandHandler,并且能够通过session字段来记录状态。

@lintanghui
Copy link
Copy Markdown
Contributor Author

另外,建议补充相关的单元测试

ctx 添加session只是方便用户添加一些wrap 本身在redis层面不太好进行测试,只要保证原来的redis 单测是兼容的即可

单测只要验证ctx能够传到用户自定义的RedisCommandHandler,并且能够通过session字段来记录状态。

已添加

@wwbmmm
Copy link
Copy Markdown
Contributor

wwbmmm commented Mar 4, 2025

LGTM
CI失败的问题可以merge master解决

@lintanghui
Copy link
Copy Markdown
Contributor Author

LGTM CI失败的问题可以merge master解决

done

@lintanghui
Copy link
Copy Markdown
Contributor Author

cc @wwbmmm

@wwbmmm wwbmmm merged commit cffbd24 into apache:master Mar 6, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants