Fix: Remove recursion of redis command parser#3136
Merged
wwbmmm merged 1 commit intoapache:masterfrom Nov 15, 2025
Merged
Conversation
howzi
changed the title
Contributor
Author
|
@chenBright take a look plz, same problem as #3099. Although |
wwbmmm
reviewed
Nov 4, 2025
src/brpc/redis_command.cpp
Outdated
| if (++_index == _length) { | ||
| break; | ||
| } | ||
| } while (true); |
Contributor
There was a problem hiding this comment.
This do-while is too long, it's hard to read. I think you can move the actual parsing code to a ConsumeImpl function, and leave this do-while structure in the Consume function.
howzi
force-pushed
the
remove_recursion_of_redis_command_parser
branch
from
571ead7 to
53587e4
Compare
Contributor
|
LGTM |
Contributor
Author
|
@wwbmmm @chenBright Is this available to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: NULL
Problem Summary: Remove recursion of redis command parser
What is changed and the side effects?
Changed: Convert RedisCommandParser::Consume to iterative state machine (remove recursion)
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: