Skip to content

Fix bvar's bad return value#3151

Merged
wwbmmm merged 1 commit intoapache:masterfrom
songqing:fix_bvar
Nov 17, 2025
Merged

Fix bvar's bad return value#3151
wwbmmm merged 1 commit intoapache:masterfrom
songqing:fix_bvar

Conversation

@songqing
Copy link
Copy Markdown
Contributor

@songqing songqing commented Nov 14, 2025

What problem does this PR solve?

Resolve issue: #3152
Problem Summary:
Fix bug.
When read stat(such as proc, memory and load) failed, we need to return false, but return -1 now, which is true instead.

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects:

  • Breaking backward compatibility:


Check List:

@wwbmmm
Copy link
Copy Markdown
Contributor

wwbmmm commented Nov 14, 2025

LGTM

@chenBright chenBright linked an issue Nov 15, 2025 that may be closed by this pull request
@songqing
Copy link
Copy Markdown
Contributor Author

@wwbmmm hi, could you help a review?

Copy link
Copy Markdown
Contributor

@chenBright chenBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wwbmmm wwbmmm merged commit a54b607 into apache:master Nov 17, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bvar return true not false when failed to read stat

3 participants