Use channels to do the write coordination in the writerCoalescer struct #1192
Conversation
| buffers = append(buffers, w.buf) | ||
| resChs = append(resChs, w.resCh) | ||
| default: | ||
| done = true |
There was a problem hiding this comment.
why not just break here? Why separate done handling?
There was a problem hiding this comment.
"break" refer to the closest "for", "switch", or "select". It would never exit the for loop L636
There was a problem hiding this comment.
oh well, of course...don't know what I was thinking, ignore :-)
There was a problem hiding this comment.
you can label the loop and then break the loop from the select, e.g.:
loop:
for {and
default:
break loopThere was a problem hiding this comment.
@nussjustin true, but in this case that would hardly improve readability.
conn_test.go
Outdated
| return | ||
| case <-t.C: | ||
| w.flush() | ||
| } | ||
| } | ||
| }() | ||
|
|
||
| if buf.Len() != 0 { |
There was a problem hiding this comment.
Now as you're writing and flushing concurrently this check doesn't really make sense...is it possible to move the write operations before the flusher?
What we basically want with this check is to make sure that writes are coalesced and happen only after the flushing, and not right away.
Thanks!
|
I thought it would be simpler to use another cond to conditionally start the flush loop #1194 |
Related to #1191