Fix copyOfRange end index in x0017 strong encryption header#786
Merged
Conversation
garydgregory
added a commit
that referenced
this pull request
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseFileFormat in X0017_StrongEncryptionHeader passes the raw ivSize/erdSize/hashSize/resize/vSize fields as the third argument to Arrays.copyOfRange, which is an end index and not a length, so every other extra-field parser in this package uses the offset+length form instead. a crafted 0x0017 local extra field where the recipient key hash starts past hashSize makes copyOfRange throw IllegalArgumentException (fromIndex > toIndex), and fillExtraField only maps ArrayIndexOutOfBoundsException to ZipException, so that runtime exception escapes uncaught out of ZIP parsing; the earlier fields are also sliced to the wrong length. compute each end index as from + size and drop the assertMinimalLength guards that only existed to dodge the from > to case, the surviving assertDynamicLengthFits/prefix checks already bound every slice so malformed input now surfaces as the declared ZipException. added X0017_StrongEncryptionHeaderTest covering the recipient-key-hash case.