Skip to content

blog post for Cordova node xcode 1.1.0 release #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2018

Conversation

brody4hire
Copy link

No description provided.

@brody4hire brody4hire requested review from janpio and dpogue December 19, 2018 17:16
@janpio janpio closed this Dec 19, 2018
@janpio janpio reopened this Dec 19, 2018
@janpio
Copy link
Member

janpio commented Dec 19, 2018

Ups, misclicked.

Does this really need a blog post? It is only slightly related to Cordova, not targeted at actual Cordova end users, and also doesn't really change anything.

author:
name: Chris Brody
url: https://twitter.com/brodybits
title: "Cordova node xcode 8.1.2 Patch Release"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.1.2??? You mean 1.1.0???

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed now

@brody4hire brody4hire merged commit 9e6e687 into apache:master Dec 21, 2018
@brody4hire brody4hire deleted the xcode-1.1.0 branch December 21, 2018 13:21
@janpio
Copy link
Member

janpio commented Dec 21, 2018

So you just merge the PR instead of answering my question?

@brody4hire
Copy link
Author

Does this really need a blog post?

I think we should add it since it can slightly change behavior on cordova-ios and cordova-osx scripts.

I think it would be ideal to move cordova-node-xcode out of the Cordova project, just raised apache/cordova-node-xcode#42.

Should we consider reverting this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants