refactor!: drop platform binaries

tests/spec/create.spec.js

@@ -17,52 +17,98 @@
  under the License.
  */
 
-const spec = __dirname;
-const path = require('path');
 const fs = require('fs-extra');
-const { superspawn } = require('cordova-common');
+const os = require('os');
+const path = require('path');
+const xcode = require('xcode');
+const create = require('../../bin/lib/create');
 
-const cordova_bin = path.join(spec, '../..', 'bin');
-const tmp = require('tmp').dirSync().name;
+const makeTempDir = () => path.join(os.tmpdir(), `cordova-ios-create-test-${Date.now()}`);
 
-function createAndBuild (projectname, projectid) {
-    const projectTempDir = path.join(`${tmp}/${projectname}`);
-    const createBin = path.join(`${cordova_bin}/create`);
-    const buildBin = path.join(`${projectTempDir}/cordova/build`);
+/**
+ * Verifies that some of the project file exists. Not all will be tested.
+ * E.g. App's resource directory, xcodeproj, xcworkspace, and CordovaLib.
+ *
+ * @param {String} tmpDir
+ * @param {String} projectName
+ */
+function verifyProjectFiles (tmpDir, projectName) {
+    expect(fs.existsSync(path.join(tmpDir, projectName))).toBe(true);
+    expect(fs.existsSync(path.join(tmpDir, `${projectName}.xcodeproj`))).toBe(true);
+    expect(fs.existsSync(path.join(tmpDir, `${projectName}.xcworkspace`))).toBe(true);
+    expect(fs.existsSync(path.join(tmpDir, 'CordovaLib'))).toBe(true);
+}
 
-    // Remove any pre-existing temp projects
-    fs.removeSync(projectTempDir);
+/**
+ * Verifies that the set bundle id matches with the expected.
+ *
+ * @param {String} tmpDir
+ * @param {String} projectName
+ * @param {String} expectedBundleIdentifier
+ */
+function verifyProjectBundleIdentifier (tmpDir, projectName, expectedBundleIdentifier) {
+    const pbxproj = path.join(tmpDir, `${projectName}.xcodeproj/project.pbxproj`);
+    const xcodeproj = xcode.project(pbxproj);
+    xcodeproj.parseSync();
+    const actualBundleIdentifier = xcodeproj.getBuildProperty('PRODUCT_BUNDLE_IDENTIFIER');
+    expect(actualBundleIdentifier).toBe(`"${expectedBundleIdentifier}"`);
+}
 
-    return superspawn.spawn(createBin, [projectTempDir, projectid, projectname], { printCommand: true }).then(
-        () => {
-            expect(true).toBe(true); // It is expected that create is successful
+/**
+ * Runs and expects for a successful build.
+ *
+ * @param {String} tmpDir
+ * @returns {Promise}
+ */
+function verifyBuild (tmpDir) {
+    const Api = require(path.join(tmpDir, 'cordova/Api.js'));
 
-            return superspawn.spawn(buildBin, ['--emulator'], { printCommand: true }).then(
-                () => {
-                    expect(true).toBe(true); // It is expected that build is successful
-                },
-                () => fail('Project Build has failed and is not expected.')
-            );
-        },
-        () => fail('Project create has failed and is not expected.')
-    ).finally(() => {
-        // Delete Temp Project
-        fs.removeSync(projectTempDir);
-    });
+    return new Api()
+        .build({ emulator: true })
+        .then(
+            () => {
+                expect(true).toBe(true);
+            },
+            err => fail(`Project Build has failed and is not expected.: ${err}`)
+        );
+}
+
+/**
+ * Runs various create and buid checks.
+ *
+ * @param {String} tmpDir
+ * @param {String} packageName
+ * @param {String} projectName
+ * @returns
+ */
+function verifyCreateAndBuild (tmpDir, packageName, projectName) {
+    verifyProjectFiles(tmpDir, projectName);
+    verifyProjectBundleIdentifier(tmpDir, projectName, packageName);
+    return verifyBuild(tmpDir);
 }
 
 describe('create', () => {
-    it('Test#001 : create project with ascii name, no spaces', () => {
-        const projectname = 'testcreate';
-        const projectid = 'com.test.app1';
+    let tmpDir;
+
+    beforeEach(function () {
+        tmpDir = makeTempDir();
+    });
 
-        return createAndBuild(projectname, projectid);
+    afterEach(() => {
+        fs.removeSync(tmpDir);
+    });
+
+    it('Test#001 : create project with ascii name, no spaces', () => {
+        const packageName = 'com.test.app1';
+        const projectName = 'testcreate';
+        return create.createProject(tmpDir, packageName, projectName, {}, undefined)
+            .then(() => verifyCreateAndBuild(tmpDir, packageName, projectName));
     }, 240 * 1000); // first build takes longer (probably cold caches)
 
     it('Test#002 : create project with complicated name', () => {
-        const projectname = '応応応応 hello & إثرا 用用用用';
-        const projectid = 'com.test.app2';
-
-        return createAndBuild(projectname, projectid);
+        const packageName = 'com.test.app2';
+        const projectName = '応応応応 hello & إثرا 用用用用';
+        return create.createProject(tmpDir, packageName, projectName, {}, undefined)
+            .then(() => verifyCreateAndBuild(tmpDir, packageName, projectName));
     }, 120 * 1000);
 });