Skip to content

refactor(run): code cleanup#1189

Merged
raphinesse merged 3 commits intoapache:masterfrom
raphinesse:cleanup-run
Nov 9, 2021
Merged

refactor(run): code cleanup#1189
raphinesse merged 3 commits intoapache:masterfrom
raphinesse:cleanup-run

Conversation

@raphinesse
Copy link
Copy Markdown
Contributor

@raphinesse raphinesse commented Nov 7, 2021

Just some code quality improvements

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 7, 2021

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.12%. Comparing base (ea9751b) to head (660d4a9).
⚠️ Report is 207 commits behind head on master.

Files with missing lines Patch % Lines
bin/templates/scripts/cordova/lib/run.js 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
+ Coverage   75.03%   75.12%   +0.09%     
==========================================
  Files          13       13              
  Lines        1650     1648       -2     
==========================================
  Hits         1238     1238              
+ Misses        412      410       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@raphinesse raphinesse changed the title refactor(run): some minor cleanup refactor(run): code cleanup Nov 9, 2021
Copy link
Copy Markdown
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@raphinesse raphinesse merged commit 4b58be0 into apache:master Nov 9, 2021
@raphinesse raphinesse deleted the cleanup-run branch November 9, 2021 08:43
@erisu erisu added this to the 7.0.0 milestone Nov 16, 2021
gazben pushed a commit to apicore-engineering/cordova-ios that referenced this pull request Aug 26, 2022
* refactor(run): merge functions startSim and iossimLaunch

* refactor(run): simplify deployToSim

* refactor(run): simplify deployToDevice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants