fix: Ensure Xcode project file references use path#1358
Merged
dpogue merged 1 commit intoapache:masterfrom Aug 29, 2023
Merged
Conversation
breautek
approved these changes
Jul 18, 2023
erisu
approved these changes
Jul 21, 2023
|
Hi @dpogue, |
Member
Author
When someone has time to put together a release and go through the voting process. Cordova is maintained by volunteers in their free time. |
|
Hi, I could not update to version 7 of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Closes GH-1357.
Description
After moving some files around in cordova-ios 7.0.0, Xcode opted to use a
nameattribute in the Xcode project file rather than apathattribute. This is valid from Xcode's perspective, but fails expectations of thenode-xcodelibrary that we use for manipulating the project file.Ensure that every file in the project has an explicit
pathspecified.Testing
...
Checklist