fix: Add missing cordova versions to CDVAvailability.h#1360
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1360 +/- ##
=======================================
Coverage 78.25% 78.25%
=======================================
Files 15 15
Lines 1789 1789
=======================================
Hits 1400 1400
Misses 389 389 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
breautek
approved these changes
Jul 20, 2023
erisu
approved these changes
Jul 20, 2023
dpogue
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is supposedly done by coho during the release process, but looks like last two releases failed to do it, so the versions are missing.
EDIT:
CDVAvailability.h file was moved, so the code in coho was not working, I've updated the path on coho
apache/cordova-coho#323