Restore stdio passthrough behavior#483
Merged
brody2consult merged 1 commit intomasterfrom Dec 19, 2018
unknown repository
Merged
Restore stdio passthrough behavior#483brody2consult merged 1 commit intomasterfrom unknown repository
brody2consult merged 1 commit intomasterfrom
unknown repository
Conversation
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
=======================================
Coverage 75.66% 75.66%
=======================================
Files 11 11
Lines 1796 1796
=======================================
Hits 1359 1359
Misses 437 437
Continue to review full report at Codecov.
|
oliversalzburg
changed the title
brody2consult
approved these changes
Dec 19, 2018
brody2consult
left a comment
brody2consult
left a comment
There was a problem hiding this comment.
Approved on my part, would like another quick review since I am not so familiar with this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
It restores the
stdiosetting that was previously applied through thespawn.jsshell execution utility.In the current setting, previously visible console output would likely be hidden from the user.
What testing has been done on this change?
None