GH-498: (ios) support old cordova-common in which no getPodSpecs function#501
Merged
dpogue merged 1 commit intoapache:masterfrom Jan 20, 2019
Merged
GH-498: (ios) support old cordova-common in which no getPodSpecs function#501dpogue merged 1 commit intoapache:masterfrom
dpogue merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #501 +/- ##
=======================================
Coverage 74.75% 74.75%
=======================================
Files 11 11
Lines 1822 1822
=======================================
Hits 1362 1362
Misses 460 460
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Cordova-iOS
What does this PR do?
Fix the issue #498 .
The old cordova-common (2.x.x) has no
getPodSpecsfunction.To support the old cordova-common, skipping call getPosSpecs function if it does not exist.
What testing has been done on this change?
as follows on local my mac.
creating project by cordova 8.1.2 (cordova-lib@8.1.1, cordova-common@2.2.5).
adding this cordova-ios platform.
checking there is no errors.
Checklist