Skip to content

CB-14135(ios): escape all single quotes from name in Podfile #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcesarmobile merged 2 commits into from
Dec 2, 2019
Merged

CB-14135(ios): escape all single quotes from name in Podfile #731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3860f6
CB-14135(ios): escape all single quotes from name in Podfile
jcesarmobile Nov 29, 2019
d102049
fix lint
jcesarmobile Nov 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/templates/scripts/cordova/lib/Podfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ Podfile.prototype.__parseForPods = function (text) {
};

Podfile.prototype.escapeSingleQuotes = function (string) {
return string.replace('\'', '\\\'');
return string.replace(/'/g, '\\\'');
};

Podfile.prototype.getTemplate = function () {
Expand Down
13 changes: 12 additions & 1 deletion tests/spec/unit/Podfile.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,20 @@ describe('unit tests for Podfile module', function () {
expect(actualProjectName).toBe(expectedProjectName);
});

it('Test 011 : escapes double single quotes in project name when writing a Podfile', function () {
podfile.before_install();

var projectName = 'l\'etat c\'est moi';

var expectedProjectName = 'l\\\'etat c\\\'est moi';
var actualProjectName = podfile.escapeSingleQuotes(projectName);

expect(actualProjectName).toBe(expectedProjectName);
});

});

it('Test 011 : tear down', function () {
it('Test 012 : tear down', function () {
podfile.destroy();

var text = '// DO NOT MODIFY -- auto-generated by Apache Cordova\n';
Expand Down