Merged
Conversation
raphinesse
requested changes
Dec 18, 2019
Contributor
raphinesse
left a comment
There was a problem hiding this comment.
I flagged a few things that I would like to see changed.
2a79ae5 to
08aa0f4
Compare
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
==========================================
+ Coverage 74.29% 74.32% +0.02%
==========================================
Files 11 11
Lines 1852 1842 -10
==========================================
- Hits 1376 1369 -7
+ Misses 476 473 -3
Continue to review full report at Codecov.
|
Member
|
I've took the liberty to resolve the minor merge conflicts via the GitHub UI. |
Member
Author
|
Thank you for fixing the merge conflicts @timbru31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Modernize code
Description
lebabto apply--transform arrowand--transform arrow-return.arrow-returnfor readability.Testing
npm t