refactor: do not alias this to self#748
Merged
erisu merged 1 commit intoapache:masterfrom Dec 24, 2019
Merged
Conversation
raphinesse
approved these changes
Dec 19, 2019
erisu
force-pushed
the
v6-transform-this-not-self
branch
from
3b54a73 to
e6c4833
Compare
erisu
force-pushed
the
v6-transform-this-not-self
branch
from
f10bb6a to
0a01163
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Creating an alias is not required if using
arrowfunctions.Description
self = thisand anything that usedself.Testing
npm t