refactor: deprecate mediaPlaybackAllowsAirPlay#785
Merged
erisu merged 2 commits intoapache:masterfrom Feb 25, 2020
Merged
Conversation
erisu
force-pushed
the
refactor/fix-mediaPlaybackAllowsAirPlay
branch
from
e26f876 to
e7b39f3
Compare
knight9999
reviewed
Feb 15, 2020
dpogue
reviewed
Feb 15, 2020
erisu
force-pushed
the
refactor/fix-mediaPlaybackAllowsAirPlay
branch
from
e7b39f3 to
1ec9232
Compare
Codecov Report
@@ Coverage Diff @@
## master #785 +/- ##
=======================================
Coverage 74.36% 74.36%
=======================================
Files 13 13
Lines 1845 1845
=======================================
Hits 1372 1372
Misses 473 473
Continue to review full report at Codecov.
|
Member
|
If both the old and the new preference are present the old one takes precedence , is that desired? |
erisu
force-pushed
the
refactor/fix-mediaPlaybackAllowsAirPlay
branch
from
1ec9232 to
03123e2
Compare
Apple has deprecated "mediaPlaybackAllowsAirPlay" in iOS 8.0-9.0. This flag should be replaced with "allowsAirPlayForMediaPlayback". Preference name has also been changed to "AllowsAirPlayForMediaPlayback"
erisu
force-pushed
the
refactor/fix-mediaPlaybackAllowsAirPlay
branch
from
03123e2 to
60795b6
Compare
Member
Author
|
@jcesarmobile When you have a chance, can you take a look at this PR again please. I flipped the order of priority. Now, the old preference value should be set first, or defaults to "YES" when missing, but if the new preference name exists, it will take higest priority and overwrite whatever was set from the old preference name. |
CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewEngine.m
Outdated
Show resolved
Hide resolved
Co-Authored-By: jcesarmobile <jcesarmobile@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Apple has deprecated the
mediaPlaybackAllowsAirPlayproperty in iOS iOS 8.0-9.0.This property should be replaced with
allowsAirPlayForMediaPlayback.https://developer.apple.com/documentation/webkit/wkwebviewconfiguration/1614726-mediaplaybackallowsairplay
Description
This PR:
AllowsAirPlayForMediaPlayback) fromconfig.xmlTesting
npm tcordova platform addcordova build iosChecklist